Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update baseline hero font sizes #404

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update baseline hero font sizes #404

wants to merge 1 commit into from

Conversation

jaymcp
Copy link
Contributor

@jaymcp jaymcp commented Sep 30, 2024

Ref: #403

Steps to test:

  1. checkout PR branch and run a build
  2. reduce screen width to a small device size
  3. see that the font sizes are reduced to a reasonable level
  4. slowly increase the screen width, and the font sizes should increase accordingly

@jaymcp jaymcp requested a review from Gentyspun September 30, 2024 09:28
Gentyspun
Gentyspun approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Gentyspun Gentyspun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jaymcp
Copy link
Contributor Author

jaymcp commented Sep 30, 2024

i should have PR'd this to staging, not develop, since this is a fix for v1.*; develop contains all of our new code for v2.0.0. updating the merge-base, which may invalidate the PR review. apologies @Gentyspun

@jaymcp
Copy link
Contributor Author

jaymcp commented Sep 30, 2024

merged into staging in b4bad97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gentyspun Gentyspun Gentyspun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaymcp @Gentyspun