Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _ to host validation #372

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add _ to host validation #372

merged 1 commit into from
Dec 10, 2024

Conversation

maximal
Copy link
Contributor

@maximal maximal commented Oct 21, 2024

Local hosts can contain underscores. For example in Docker contexts (application/services names).

kelunik
kelunik reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@kelunik kelunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... underscores are not valid in hostnames or domain labels as far as I know.

Any reason why you try to use underscores instead of dashes?

@trowski trowski merged commit 97a40cc into amphp:3.x Dec 10, 2024
6 checks passed
@maximal maximal deleted the patch-1 branch December 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximal @kelunik @trowski