Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token vault #6

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Token vault #6

merged 2 commits into from
Jan 6, 2021

Conversation

aalavandhan
Copy link
Member

@aalavandhan aalavandhan commented Dec 18, 2020 •
edited
Loading

  • Token vault contract which allows whitelisted gateways to lock/unlock erc20 tokens
  • Deployed on the main-chain. Interacts with whitelisted bridgeGateways.

@aalavandhan aalavandhan changed the base branch from master to xc-policy December 18, 2020 17:22
Base automatically changed from xc-policy to master December 18, 2020 19:27
@aalavandhan aalavandhan requested a review from thegostep January 4, 2021 19:35
thegostep
thegostep approved these changes Jan 4, 2021
View reviewed changes
Copy link

@thegostep thegostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I like the simple implementation as is pushes the complexity to the off-chain service

contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
contracts/TokenVault.sol Show resolved Hide resolved
@aalavandhan aalavandhan merged commit 521668c into master Jan 6, 2021
@aalavandhan aalavandhan deleted the token-vault branch January 7, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegostep thegostep thegostep approved these changes

@brandoniles brandoniles Awaiting requested review from brandoniles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalavandhan @thegostep