Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the staticFiles variable name & defaultSettings merge #216

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

levivannoort
Copy link
Member

@levivannoort levivannoort commented Oct 23, 2023

Fixes: amplication/amplication#7312

PR Details

PR Checklist

  • Tests for the changes have been added
  • npm build doesn't throw any error
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@levivannoort levivannoort marked this pull request as ready for review October 23, 2023 12:53
Copy link
Contributor

@overbit overbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the plugin-template repo too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: error on variable name & not merge defaultSetting on plugin-template
3 participants