forked from trixi-framework/Trixi.jl
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi ion collision sources subcell #10
Open
amrueda
wants to merge
428
commits into
multi_ion_collision_sources
Choose a base branch
from
multi_ion_collision_sources_subcell
base: multi_ion_collision_sources
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multi ion collision sources subcell #10
amrueda
wants to merge
428
commits into
multi_ion_collision_sources
from
multi_ion_collision_sources_subcell
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rixi.jl into ma-bolm-2022-indices
…pressure positivity limiter
…d removed the plotting of alpha_rho for other quantities when indicator.DensityAlphaForAll==true
…a_eff for StructuredMesh
…ation Co-authored-by: Benjamin Bolm <[email protected]>
…d multiple dispatch
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
…vative equations Co-authored-by: Benjamin Bolm <[email protected]>
Co-authored-by: Benjamin Bolm <[email protected]>
…y_nonconservative Add support for non nonconservative equations to subcell-limiting
* Revise bounds check for MCL * Rename `idp_bounds_delta` for MCL to `mcl_bounds_delta` * Remove comment * Fix allocs (trixi-framework#1695) * Fix allocs * remove unnecessary code * rerun fmt * format * Allocation tests dgmulti 2d (trixi-framework#1698) * HLLE CEE 2D3D NonCartesian Meshes (trixi-framework#1692) * HLLE CEE 2D3D NonCartesian Meshes * format * hlle via hll * format test * format test * format * do not export hlle * Correct test vals * test values CI * Update src/equations/compressible_euler_2d.jl Co-authored-by: Hendrik Ranocha <[email protected]> * Update src/equations/compressible_euler_1d.jl Co-authored-by: Hendrik Ranocha <[email protected]> * Update src/equations/compressible_euler_2d.jl Co-authored-by: Hendrik Ranocha <[email protected]> * Update src/equations/compressible_euler_3d.jl Co-authored-by: Hendrik Ranocha <[email protected]> * Update src/equations/compressible_euler_3d.jl Co-authored-by: Hendrik Ranocha <[email protected]> * apply suggestions * additional sentence * Fix typo * typos * correct test vals --------- Co-authored-by: Hendrik Ranocha <[email protected]> * Bump crate-ci/typos from 1.16.15 to 1.16.21 (trixi-framework#1700) Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.16.15 to 1.16.21. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.16.15...v1.16.21) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add NumFOCUS + ACTRIX to acknowledgments (trixi-framework#1697) * Add NumFOCUS + ACTRIX to acknowledgments * Try to avoid spaces * Another try to avoid gaps between images * Hopefully fix image alignment in docs * Try new logo formats * Use smaller DUBS logo and add DUBS funding statement * Add markdown-based table for logos in docs * Try another table approach * Hopefully get a layout that finally *works*... * Arrrrrrgggggghhhhh * format examples (trixi-framework#1531) * format examples * check formatting of examples in CI * update style guide * fix weird formatting * fix formatting of binary operators * format again * Update differentiable_programming.jl (trixi-framework#1704) * Format subcell elixirs * Add warning for missing bounds check for entropy limiter (MCL) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Daniel Doehring <[email protected]> Co-authored-by: Hendrik Ranocha <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Schlottke-Lakemper <[email protected]> Co-authored-by: ArseniyKholod <[email protected]>
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.