Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Implement mimetic metrics #3

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

WIP: Implement mimetic metrics #3

wants to merge 19 commits into from

Conversation

amrueda
Copy link
Owner

@amrueda amrueda commented Jul 13, 2023

No description provided.

amrueda added 12 commits July 13, 2023 09:14
@amrueda
Started to implement mimetic metrics
f956ac1
@amrueda
Added most of the mimetic metrics computations (only analytic project…
6273c2a 
…ion is needed)
@amrueda
Fixed some bugs
31e226a
@amrueda
Added analytical projection of metric potential (for a particular exa…
873762a 
…mple)
@amrueda
Fixed some bugs
34e1550
@amrueda
Fixed bugs. FIRST WORKING VERSION.
2955482
@amrueda
Added scripts to test the metric terms
134ff69
@amrueda
Added computation of exact jacobian matrix (potentential) before proj…
ba66691 
…ection for standard metric terms... And test with periodic and Dirichlent BCs
@amrueda
Implemented multi-element mappings
9e0235b
@amrueda
Added computation of the metric terms with standard curl (as opposed …
d9ccd49 
…to defaut curl invariant) form
@amrueda
First working version of the mimetic metrics and exact_jacobian with …
ee9a0b2 
…the p4estMesh FOR CONFORMING STRUCTURED MESHES

-> Single and multi-element cases work
-> The exact Jacobian and mimetic metrics are only implemented for the warped mesh test
-> Since this is a structured mesh, it must be initialized with a single tree in each direction!
-> Uniform refinement works (conforming meshes) but non-conforming meshes do not work yet!
@amrueda
p4est example uses a non-conforming grid
d18fa7c
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5623936772

  • 22 of 287 (7.67%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 95.234%
Changes Missing Coverage Covered Lines Changed/Added Lines %
examples/p4est_3d_dgsem/elixir_test_mimetic_metrics.jl 0 10 0.0%
src/solvers/dgsem_p4est/containers_3d.jl 16 26 61.54%
examples/structured_3d_dgsem/elixir_advection_free_stream_mimetic_metrics.jl 0 33 0.0%
examples/structured_3d_dgsem/elixir_advection_free_stream_mimetic_metrics_dirichlet.jl 0 33 0.0%
src/solvers/dgsem_structured/containers_3d.jl 6 185 3.24%
Totals Coverage Status
Change from base Build 5540190985: -0.8%
Covered Lines: 29836
Relevant Lines: 31329
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrueda @coveralls @dlbach