Styles all the blogs #526
Styles all the blogs #526
Conversation
Signed-off-by: akanksha984 <[email protected]>
Signed-off-by: akanksha984 <[email protected]>
Signed-off-by: akanksha984 <[email protected]>
Signed-off-by: akanksha984 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you, @akanksha984, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
Signed-off-by: akanksha984 <[email protected]>
pages/blog/[blogId].js
Outdated
| width="5000%" | ||
| height="2000%" |
There was a problem hiding this comment.
This is weird. Can you please find more robust and sensible way to deal with height and width? Think in other metrics like vh and vw if you have issues with percentage?
There was a problem hiding this comment.
@akanksha984 Design wise it looks beautiful. Can you just find another way for width and height ?
Signed-off-by: akanksha984 <[email protected]>
Signed-off-by: akanksha984 <[email protected]>
|
Fixed it @Harshil-Jani |
|
@Harshil-Jani sir are the changes up to mark ? |
There was a problem hiding this comment.
@akanksha984 Thanks for the change. I was reviewing the deployment and I observed two things which sounds good to have/improve.
- (in mobile view) Header for few blogs is different (less in width) from others. (Eg: SQL, screenshot below)
- In mobile view this is not looking good enough. Images are resized and not visible.
Can you please add some media quries so this looks beautiful on the mobile screens as well ?
Signed-off-by: akanksha984 <[email protected]>
Signed-off-by: akanksha984 <[email protected]>
Signed-off-by: akanksha984 <[email protected]>
Signed-off-by: akanksha984 <[email protected]>
|
@Harshil-Jani I think it is responsive now please check it |
|
@akanksha984 Thanks for the changes. This looks amazing now. There is a shift of branches and we are now accepting changes into the |
|
How do we resolve the conflicts, I mean I can see the conflict but what is the conflict and how to fix it please guide @Harshil-Jani |
|
Has it been resolved now @Harshil-Jani I have edited it and then clicked on sign off the commit to main |
|
Hey @akanksha984 I suggest reading
If you are still facing hard time resolving merge conflicts ping me back I can help to do that. |
Signed-off-by: akanksha984 <[email protected]>
|
Can you check it now @Harshil-Jani . I think it is fine now. |
|
@Harshil-Jani please review it |
|
Hey @akanksha984 I think there is some error. The deployment is failing. Can you try checking and resolving the error on local using |
Signed-off-by: Akanksha Chaurasia <[email protected]>
|
@Harshil-Jani please check it now, It should be fine now I hope |
|
Hey @akanksha984 For resolving the build errors I see that you removed lazy-loading attributes. We have a PR on this #534. So Can you show us the error? Because I think removing them in order to solve the issues is not a solution until it increases the complexity of the project. |
I have just pasted the code i had written and it created no issue. Last time there was issue i resolved that still there was error in deployment |
Signed-off-by: Akanksha Chaurasia <[email protected]>
Signed-off-by: Akanksha Chaurasia <[email protected]>
|
@Harshil-Jani can you please help why deployment is failing ? |
|
@Harshil-Jani its working well on local but failing here. If you could help me out it would be great help |
Signed-off-by: Akanksha Chaurasia <[email protected]>
Signed-off-by: Akanksha Chaurasia <[email protected]>
|
@Harshil-Jani @anmode please check it once is it ok now ? |
|
@anmode please look into it |
Description
I have styled all the blogs. Issue: #495
image
Pull Request Checklist
Please make sure that your PR meets the following requirements:
The app is working correctly after applying the changes.
The app is responsive and displays properly on different screen sizes and devices.
The changes are thoroughly documented in the appropriate files or documentation sections.
The coding conventions and style guidelines are followed consistently.
Checklist
Please check all applicable boxes and provide any additional information if needed.
[ x] I have tested the changes locally and ensured that the app is functioning as expected.
[ x] I have verified that the app is responsive and looks good on various screen sizes and devices.
[ x] I have reviewed the documentation and ensured that it accurately reflects the changes made.
[ x] I have followed the coding conventions and style guidelines defined in the project.
[ x] I have run the automated tests and all of them pass.
[ x] I have considered the performance implications of the changes made.
[ x] I have considered the security implications of the changes made.
[ x] I have checked for any potential regressions or side effects caused by the changes.
[ x] I have performed a self-review of my code.
[ x] Starred the repository.
Added My Name to the Contributor's List.
[ x] Followed the repository's Contributing Guidelines.
[ x] I ran the app and tested it locally to verify that it works as expected.
Screenshots - If Any (Optional)
Additional Notes(Optional)
Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
closed #495
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
@Harshil-Jani
Please tag the relevant team members or reviewers who should review this pull request.