fix(SharedStyle): delegate args to Shared.TextStyle properly (#85)

fixes #84
amzn · Jan 30, 2020 · 48f5db5 · 48f5db5
1 parent 4fc6fe2
commit 48f5db5
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 4 deletions.
diff --git a/__examples__/generating-sketch-from-style-dictionary/sketch/index.js b/__examples__/generating-sketch-from-style-dictionary/sketch/index.js
@@ -26,8 +26,10 @@ module.exports = function BuildSketchWithStyles(dictionary) {
     const font = dictionary.properties.component.typography[key];
     sketch.addTextStyle({
       name: key,
-      fontSize: font['font-size'].value,
-      color: font.color.value,
+      textStyle: {
+        fontSize: font['font-size'].value,
+        color: font.color.value,
+      },
     });
   });
 

diff --git a/models/SharedStyle/SharedStyle.js b/models/SharedStyle/SharedStyle.js
@@ -12,7 +12,6 @@
  */
 
 const uuid = require('uuid-v4');
-const TextStyle = require('../TextStyle');
 const Style = require('../Style');
 
 class SharedStyle {
@@ -32,7 +31,7 @@ class SharedStyle {
     return new SharedStyle({
       name: args.name,
       id,
-      textStyle: new TextStyle(Object.assign(args, { id })),
+      textStyle: args.textStyle,
     });
   }
 

diff --git a/models/SharedStyle/SharedStyle.test.js b/models/SharedStyle/SharedStyle.test.js
@@ -40,4 +40,20 @@ describe('SharedStyle', () => {
       expect(layerStyle.value.fills[0].color.red).toEqual(1);
     });
   });
+
+  describe('TextStyle', () => {
+    it('should work', () => {
+      const textStyle = SharedStyle.TextStyle({
+        name: 'test',
+        textStyle: {
+          fontName: 'Arial',
+          fontSize: 10,
+        },
+      });
+      expect(textStyle.value.textStyle.encodedAttributes.MSAttributedStringFontAttribute.attributes).toEqual({
+        name: 'Arial',
+        size: 10,
+      });
+    });
+  });
 });