Add support and doc for AD7124 #19
Conversation
D-Disha
requested review from
ribdp,
SaikiranGudla,
jansunil and
CMinajigi
as code owners
|
|
|
Hi all, are there any comments on this PR? |
|
|
||
| % Samples per frame cannot exceed 500 if all 16 channels need to be captured on ad7124-8 | ||
| rx.SamplesPerFrame = 500; | ||
| rx.EnabledChannels = [1 2 3 4 5 6 7 8]; |
There was a problem hiding this comment.
Should we enable all 16 channels if the chosen device is AD7124-8?
There was a problem hiding this comment.
I think the example script should be catered to ad7124-4 as it is default device on firmware also. I would change the example script accordingly.
| flushBuffers(obj); | ||
| end | ||
|
|
||
| function delete(obj) |
There was a problem hiding this comment.
nit: Can add comment "% Destructor" here
+adi/+AD7124_4/Rx.m
Outdated
| % data from the AD7124-4. | ||
| % | ||
| % rx = adi.AD7124_4.Rx; | ||
| % rx = adi.AD7124_4.Rx('uri','192.168.2.1'); |
There was a problem hiding this comment.
Add "ip:" prior to the address
+adi/+AD7124_8/Rx.m
Outdated
| % data from the AD7124-8. | ||
| % | ||
| % rx = adi.AD7124_8.Rx; | ||
| % rx = adi.AD7124_8.Rx('uri','192.168.2.1'); |
There was a problem hiding this comment.
Add "ip:" prior to the address
|
Hi all, are there any more comments on this PR? |
+adi/+AD7124/Base.m
Outdated
| obj.phyDevName = phydev; | ||
| obj.devName = dev; | ||
|
|
||
| % Check if uri has been specified, else throw an error |
There was a problem hiding this comment.
This would work, but if there's not an express need to connect to the device during instantiation, we can drop this (lines 53 - 71).
We could then modify the example scripts to set the uri after the instantiation.
There was a problem hiding this comment.
My reasoning here is, there exists a more concise way of parsing input arguments - but in the context of this driver, we don't need the user to provide the uri at init time, at all.
So long as they set it before calling the system object ( data = rx() ), it shouldn't be an issue.
There was a problem hiding this comment.
Makes sense. I have made the changes
D-Disha
force-pushed
the
ad7124_support
branch
2 times, most recently
from
87e1423 to
acd6e89
Compare
Signed-off-by: Disha D <[email protected]>
|
Hi all, are there any more comments on this PR? |
Add precision toolbox support for AD7124-4 and AD7124-8.