Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx documentation #25

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add sphinx documentation #25

merged 1 commit into from
Apr 10, 2024

Conversation

ribdp
Copy link
Contributor

@ribdp ribdp commented Apr 3, 2024

Pull Request Description

Migrate documentation from markdown and mkdocs, to rst and Sphinx
Add script to be run for code documentation
Update the documentation workflow to build the sphinx docs

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation by running CI/gen_doc/docs/gen_sysobj_doc.m script locally, if applies.

@ribdp ribdp force-pushed the add-sphinx-documentation branch 2 times, most recently from af989d9 to e05eaa5 Compare April 3, 2024 10:11
@ribdp ribdp marked this pull request as ready for review April 3, 2024 10:34
@ribdp
Copy link
Contributor Author

ribdp commented Apr 4, 2024

Hi all, any comments here?

@@ -70,10 +70,16 @@
all_props = [all_props,s];
end
top_doc = help(dotmfilename);
disp("Hello")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of this step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was an older commit wherein I had added that line as a debug step. It's been removed in one of the subsequent commits.

The commit history is honestly not the cleanest. I'll squash the commits in the end before merging.

@ribdp
Copy link
Contributor Author

ribdp commented Apr 5, 2024

Hi @jansunil , @SaikiranGudla , @CMinajigi - any further comments?

@ribdp
Copy link
Contributor Author

ribdp commented Apr 5, 2024

Just fyi, you can check out the built documentation here - https://analogdevicesinc.github.io/PrecisionToolbox/

jansunil
jansunil previously approved these changes Apr 5, 2024
SaikiranGudla
SaikiranGudla previously approved these changes Apr 5, 2024
1. Add sphinx conf and makefile
2. Add common files and images
3. Add script to generate rst files for projects and to add to index
4. Modify comments for driver classes to allow code documentation

Signed-off-by: RibhuDP <[email protected]>
@ribdp ribdp dismissed stale reviews from SaikiranGudla and jansunil via bee62a7 April 10, 2024 03:54
@ribdp ribdp force-pushed the add-sphinx-documentation branch from e05eaa5 to bee62a7 Compare April 10, 2024 03:54
@ribdp ribdp merged commit 7f6c526 into main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants