adi: Add support for AD4052 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribdp
force-pushed
the
add-ad405x-drivers
branch
3 times, most recently
from
01ce48b to
1e26742
Compare
+adi/+AD405x/Base.m
Outdated
| % integer. | ||
| SamplesPerFrame = 400 | ||
|
|
||
| % BurstAveragingLength Burst Averaging Length |
There was a problem hiding this comment.
nit: Format extra space
+adi/+AD405x/Base.m
Outdated
| % Length of the averaging filter in 'burst averaging mode' | ||
| AvgFilterLength = 2 | ||
|
|
||
| % BurstSampleRate Burst Sample Rate |
| end | ||
|
|
||
| function set.AvgFilterLength(obj, value) | ||
| % Setter method for the Averaging Filter Length attribute |
There was a problem hiding this comment.
nit: Can format comment spacing in-line with the line 85. Same comment for line 93.
docs/source/reference_api/index.rst
Outdated
| @@ -0,0 +1,37 @@ | |||
| Reference APIs | |||
There was a problem hiding this comment.
Shall this change be reflected in the commit message as this is not specific to ad405x doco?
| @@ -11,9 +11,9 @@ jobs: | |||
| with: | |||
| submodules: recursive | |||
| - name: Set up Python 3.7 | |||
| uses: actions/setup-python@v2 | |||
| uses: actions/setup-python@v5 | |||
There was a problem hiding this comment.
Should this be part of a separate commit (maybe the previous one on documentation) and a relevant message be added to the commit?
ribdp
force-pushed
the
add-ad405x-drivers
branch
3 times, most recently
from
47c4cf3 to
7f8d09a
Compare
1. Add AD405x family driver base class 2. Add AD4052 Receive rx class 3. Add AD4052 data capture example Signed-off-by: RibhuDP <[email protected]>
1. Add reference to reference api index 2. Generate documentation from comments Signed-off-by: RibhuDP <[email protected]>
1. Update pull request template instruction for doc build 2. Update requirements and doc.yml for sphinx installation Signed-off-by: RibhuDP <[email protected]>
SaikiranGudla
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PR Type
PR Checklist