Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the AD405x MATLAB scripts #36

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Shetty-Anush
Copy link
Contributor

Pull Request Description

  1. Added the Rx System Object for AD4050
  2. Modified the data capture script to include AD4050
  3. Deleted the Rx.m script from the +AD405x folder

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation by running /docs/source/reference_api/gen_sysobj_doc.m script locally, if applies.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

@SaikiranGudla
Copy link
Collaborator

@Shetty-Anush, Can you add this part to docs/source/index.rst to reflect in the doco?

@Shetty-Anush
Copy link
Contributor Author

Do I squash the commits?

@SaikiranGudla
Copy link
Collaborator

@Shetty-Anush, Can you add this part to docs/source/index.rst to reflect in the doco?

Yes, you can squash and merge

@SaikiranGudla
Copy link
Collaborator

@Shetty-Anush, Can you add this part to docs/source/index.rst to reflect in the doco?

Yes, you can squash and merge

Also, for changes like these, try amending the commit itself and adding a change log in the comments in future!

1. Added the Rx System Object for AD4050
2. Modified the data capture script to include AD4050
3. Deleted the Rx.m script from the +AD405x folder
4. Updated index.rst and Contents.m files.

Signed-off-by: Anush Shetty <[email protected]>
@SaikiranGudla SaikiranGudla merged commit b28198c into analogdevicesinc:main Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants