Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWMSCALE Typo bug in some TMCXXXX_HW_Abstraction.h #65

Open
raffitaff opened this issue Dec 20, 2024 · 0 comments
Open

PWMSCALE Typo bug in some TMCXXXX_HW_Abstraction.h #65

raffitaff opened this issue Dec 20, 2024 · 0 comments

Comments

@raffitaff
Copy link

For the TMC2209 IC, the definition for #PWMSCALE is presumably missing the underscore (line 49).

This definition is intended to be used in lines 296 and 299 with the underscore PWM_SCALE. This would also be consistent naming convention as PWM_AUTO.

I do not currently use any other TMC ICs, but if this change is approved then this typo could be present in other ICs.

Doing a quick search in the other ICs, using PWMSCALE is consistent in the initial definition, but the use in the associated *_FIELD defines is inconsistent.

For example:

Several ICs like the 2208, 2209, 2224, 2225, 2226, and 5160 define PWMSCALE but then use PWM_SCALE in the *_field definitions.
Several ICs like the 2300, 2240, and 5240 define PWMSCALE and use PWMSCALE (versus PWM_SCALE) in the *_field definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant