Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #define PWM_SCALE typos in various IC HWAbstraction files #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raffitaff
Copy link

Noticed that the #define TMC****_PWM_SCALE implementation was wrong in a few IC's due to a typo while also having inconsistent naming across the ICs.

For instance, some defined the register as PWMSCALE AND THEN USED PWM_SCALE in the definition of the register field macro. This would cause warnings and errors if attempting to used the field macro for this register.

Some ICs like TMC2240 had consistent naming of PWMSCALE between the register define and field define. But I updated to 'PWM_SCALE' in these cases to be consistent with other ICs and the IC documentation naming convention.

Note: TMC5130 also incorrectly defined PWM_SCALE as PWM_STATUS at register 0x71. This was fixed.

This is a PR for Issue #65 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant