Fixed #define PWM_SCALE typos in various IC HWAbstraction files #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the
#define TMC****_PWM_SCALE
implementation was wrong in a few IC's due to a typo while also having inconsistent naming across the ICs.For instance, some defined the register as
PWMSCALE
AND THEN USEDPWM_SCALE
in the definition of the register field macro. This would cause warnings and errors if attempting to used the field macro for this register.Some ICs like TMC2240 had consistent naming of
PWMSCALE
between the register define and field define. But I updated to 'PWM_SCALE' in these cases to be consistent with other ICs and the IC documentation naming convention.Note: TMC5130 also incorrectly defined
PWM_SCALE
asPWM_STATU
S at register0x71
. This was fixed.This is a PR for Issue #65 .