Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad9081: common: ad9081_fmca_ebz_bd: Fix ad_mem_interconnect clock #1487

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ad9081: common: ad9081_fmca_ebz_bd: Fix ad_mem_interconnect clock #1487

wants to merge 2 commits into from
+7 −5

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Oct 10, 2024

PR Description

The ad_mem_hp1_interconnect for rx_dma was set to $sys_cpu_clock instead of $sys_dma_clock

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan
ad9081: common: ad9081_fmca_ebz_bd: Fix ad_mem_interconnect clock
5ce271b 
Was previously set to $sys_cpu_clock instead of $sys_dma_clock

Signed-off-by: Bogdan Luncan <[email protected]>
@podgori podgori self-requested a review October 10, 2024 14:47
PopPaul2021
PopPaul2021 previously approved these changes Oct 11, 2024
View reviewed changes
@bluncan bluncan added the bug label Nov 8, 2024
FilipG24
FilipG24 previously approved these changes Nov 12, 2024
View reviewed changes
@bluncan bluncan dismissed stale reviews from FilipG24 and PopPaul2021 via 48b5beb November 21, 2024 08:41
@bluncan bluncan force-pushed the ad9081_sys_dma_clock_fix branch from 48b5beb to 3c6e77a Compare November 21, 2024 08:41
@bluncan
Copy link
Contributor Author

bluncan commented Nov 21, 2024

RetriggerCI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipG24 FilipG24 FilipG24 approved these changes

@acostina acostina acostina approved these changes

@PopPaul2021 PopPaul2021 PopPaul2021 left review comments

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@AndrDragomir AndrDragomir Awaiting requested review from AndrDragomir AndrDragomir is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@podgori podgori Awaiting requested review from podgori

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bluncan @acostina @FilipG24 @PopPaul2021