fw0.32/spike_bug: fix glitch glitch between pushes to cyclic buffers #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adrian-Stanea
changed the title
AlexandraTrifan
requested changes
Dec 7, 2023
- Toggling the raw enable flag when a cyclic buffer is destroyed has the effect of sending the raw value to the ouput untill a new buffer is created. - This solves a bug where a spike appeared in between pushes to cyclic buffers because the new one would start with the last sample from the previously deleted buffer. Signed-off-by: Adrian Stanea <[email protected]>
- when these functions are called the output of the corresponding channel should be set to the specified value - the change should be reflected in the iio channel raw attribute for dac-a and dac-b Signed-off-by: Adrian Stanea <[email protected]>
- show how the setVoltage and setVoltageRaw functions work - Used to test correct implementation of the set functions. - NOTE: raw_enable attribute should be set to enalbed in order for the DAC output to be updated with the new value. Signed-off-by: Adrian Stanea <[email protected]>
Adrian-Stanea
force-pushed
the
fw0.32/spike_bug
branch
from
b92dc30 to
33a0f5f
Compare
For older fw versions, throw an exception if the user tries to set the raw attribute value. Signed-off-by: AlexandraTrifan <[email protected]>
AlexandraTrifan
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new attribute to control the output of analog out in the time between destroy and create of a cyclic kernel buffer.
The output during this time will be the raw value of the channel.
Also exposed a set function which writes to the raw attr in the analogOut class.