fix(BLE): Add WSF Terminal flush on Console UART error #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,7 +94,12 @@ void UART_CommonHandler(mxc_uart_regs_t *uart) | |||
| { | |||
| const uint8_t uartIdx = MXC_UART_GET_IDX(uart); | |||
|
|
|||
| if( uartIdx == CONSOLE_UART || uartIdx == HCI_UART) | |||
| if(uartIdx == CONSOLE_UART) | |||
There was a problem hiding this comment.
Does this solve the problem we're having? I haven't seen RX errors in the testing that I've done.
There was a problem hiding this comment.
I have gotten a handful of overflow errors when it is automated. You probably won't when manually doing it. It used to be an assertion that fired off, which happened 5-10% of runs. It is my best guess right now for the no action bound issue I see.
There was a problem hiding this comment.
I think we're better off preventing the overflow with slower writes from the automation.
There was a problem hiding this comment.
I will close it if you want, but we can't guarantee that the issue wont happen regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cordio has no way to report an error upon a hardware failure such as framing or overflow. This will lead to a parser failure. If you are unlucky and get stuck in a place where the new lines are messed up, it may lead to constant bad commands