Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Examples,PeriphDrivers): Fix clock option value setting for UART-… #1284

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

kilicomercan
Copy link
Contributor

…IBRO and UART-ERTCO clocks in MAX78000.

Description

-> UART3 is has low power capability and it works with IBRO and ERTCO clocks. We must set UART3_CTRL->bclksrc register bits to a value between 0-3. IBRO and ERTCO is defined as 2 and 3 in the MAX78000 user guide. However, the correct values seem to be 0 and 1 to set UART baudrate clock source to IBRO and ERTCO clocks respectively.
image

-> I updated the function definitions for the part to make the UART example work successfully. I tested the code for both clock options with MAX78000 FTHR.
image

UART3 is initialized with IBRO clock by default in the example.

@github-actions github-actions bot added the MAX78000 Related to the MAX78000 (AI85) label Dec 3, 2024
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Omercan.

These UART clock source settings in uart_me17.c and uart_ai85.c have been updated countless times because of the incorrect user guide. (I guess that also means some reviewers and developers don't test or verify changes... lol).

Anyways, I've submitted a Jira ticket a while ago, and these changes have been addressed internally and will be visible when the updated UGs are published.

@sihyung-maxim sihyung-maxim merged commit ff1b441 into analogdevicesinc:main Dec 4, 2024
11 checks passed
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX78000 Related to the MAX78000 (AI85)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants