Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): Calculate I3C timeout based on data size #1296

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(PeriphDrivers): Calculate I3C timeout based on data size #1296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions Libraries/PeriphDrivers/Source/I3C/i3c_reva.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,8 @@ int MXC_I3C_RevA_Controller_Transaction(mxc_i3c_reva_regs_t *i3c, const mxc_i3c_
int ret;
uint8_t readCount;
uint16_t remaining;
uint32_t timeout;
uint32_t freq;

if (MXC_I3C_RevA_Controller_GetState(i3c) != MXC_V_I3C_REVA_CONT_STATUS_STATE_IDLE &&
MXC_I3C_RevA_Controller_GetState(i3c) != MXC_V_I3C_REVA_CONT_STATUS_STATE_SDR_NORM) {
Expand All @@ -598,10 +600,12 @@ int MXC_I3C_RevA_Controller_Transaction(mxc_i3c_reva_regs_t *i3c, const mxc_i3c_
if (!req->is_i2c) {
ret = MXC_I3C_RevA_EmitStart(i3c, req->is_i2c, MXC_I3C_TRANSFER_TYPE_WRITE,
MXC_I3C_BROADCAST_ADDR, 0);

if (ret < 0) {
goto err;
}
freq = MXC_I3C_RevA_GetPPFrequency(i3c);
} else {
freq = MXC_I3C_RevA_GetI2CFrequency(i3c);
}

/* Restart with write */
Expand All @@ -612,7 +616,13 @@ int MXC_I3C_RevA_Controller_Transaction(mxc_i3c_reva_regs_t *i3c, const mxc_i3c_
goto err;
}

ret = MXC_I3C_RevA_WriteTXFIFO(i3c, req->tx_buf, req->tx_len, true, 100);
/* A simple linear estimation to find a reasonable write timeout value,
proportional to clock period and buffer size. Coefficient value has
been found by trial-and-error.
*/
timeout = (uint32_t)(40 * 1000000 / freq) * req->tx_len;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful to add a comment on what the formula is or how this timeout calculation was derived.


ret = MXC_I3C_RevA_WriteTXFIFO(i3c, req->tx_buf, req->tx_len, true, timeout);
if (ret < 0) {
goto err;
}
Expand All @@ -633,8 +643,14 @@ int MXC_I3C_RevA_Controller_Transaction(mxc_i3c_reva_regs_t *i3c, const mxc_i3c_
goto err;
}

/* A simple linear estimation to find a reasonable read timeout value,
proportional to clock period and buffer size. Coefficient value has
been found by trial-and-error.
*/
timeout = (uint32_t)(80 * 1000000 / freq) * readCount;

ret = MXC_I3C_RevA_ReadRXFIFO(i3c, req->rx_buf + (req->rx_len - remaining), readCount,
1000);
timeout);
if (ret == readCount) {
remaining -= readCount;
} else {
Expand Down
Loading