feat(Other): Add zephyr CAN wrapper for MAX32662, MAX32690 #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ioan Dragomir <[email protected]>
sihyung-maxim
approved these changes
Dec 19, 2024
MaureenHelm
approved these changes
Dec 19, 2024
|
It seems that the actions triggered by this PR being merged didn't run successfully - they were cancelled when #1305 was merged seconds later, and its actions took priority. Would it be possible for a maintainer to re-run this PR's workflows? Actions / Workflow runs that got cancelled: It also looks like the same thing happened with PR #1307, which got cancelled by this one. |
|
Nevermind, I didn't notice that the files were indeed copied to hal_adi by the latest run, even if from another PR. |
EricB-ADI
pushed a commit
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Ioan Dragomir <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MSDK API for
MXC_CAN_Initdiffers between the MAX32662 and MAX32690 boards. The former expects an additional GPIO configuration parameter. In Zephyr, because GPIO config is done by the zephyr layer and not msdk, this parameter is unused anyways (seeMSDK_NO_GPIO_CLK_INIT).This PR adds a
Wrap_MXC_CAN_Initfunction to allow thecan_max32driver (currently only available via innersource) to work on the MAX32662 as well (it currently only supports MAX32690). This seems to be the only tweak required to support this board.I have tested that this properly works with a basic CAN send-recv example on a MAX32662 board and that it builds successfully for the MAX32690.
Checklist Before Requesting Review