feat(Other): Add MAX78000 to Zephyr folder #1313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds MAX78000 SoC into the zephyr build system Signed-off-by: Yasin Ustuner <[email protected]>
This commit adds i2c related clock definitions for MAX78000 SoC Signed-off-by: Yasin Ustuner <[email protected]>
github-actions
bot
added
MAX78000
yasinustunerg
changed the title
hfakkiz
requested changes
Dec 24, 2024
| @@ -144,7 +145,7 @@ static inline int Wrap_MXC_TMR_GetClockIndex(int z_clock) | |||
| return MXC_TMR_EXT_CLK; | |||
| case 2: // ADI_MAX32_PRPH_CLK_SRC_IBRO | |||
| return MXC_TMR_8M_CLK; | |||
| #if !defined(CONFIG_SOC_MAX78002) | |||
| #if !defined(CONFIG_SOC_MAX78002) && !defined(CONFIG_SOC_MAX778000) | |||
hfakkiz
reviewed
Dec 24, 2024
| ) | ||
| endif() | ||
|
|
||
| if (CONFIG_SOC_FLASH_MAX32) |
There was a problem hiding this comment.
Please add "CONFIG_HWINFO_MAX32" to if statement of HWINFO driver's dependencies (AES, FLC and TRNG). (Related PR)
hfakkiz
reviewed
Dec 24, 2024
| @@ -57,7 +57,8 @@ static inline void Wrap_MXC_SYS_SetClockDiv(int div) | |||
| #elif defined(CONFIG_SOC_MAX32690) || defined(CONFIG_SOC_MAX32655) || \ | |||
| defined(CONFIG_SOC_MAX32670) || defined(CONFIG_SOC_MAX32672) || \ | |||
| defined(CONFIG_SOC_MAX32662) || defined(CONFIG_SOC_MAX32675) || \ | |||
| defined(CONFIG_SOC_MAX32680) || defined(CONFIG_SOC_MAX32657) || defined(CONFIG_SOC_MAX78002) | |||
| defined(CONFIG_SOC_MAX32680) || defined(CONFIG_SOC_MAX32657) || \ | |||
| defined(CONFIG_SOC_MAX78002) || defined(CONFIG_SOC_MAX78000) | |||
There was a problem hiding this comment.
Please handle clock differences here. "MXC_SYS_CLOCK_ERFO" macro is not defined for MAX78000.
hfakkiz
reviewed
Dec 24, 2024
| /* | ||
| * This function is called during boot up. | ||
| */ | ||
| void max32xx_system_init(void) {} |
There was a problem hiding this comment.
As I see, "MXC_ICC_Enable(MXC_ICC0)" line is required in here. Please check system_max78000.c file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MAX78000 SoC into the zephyr build system
Signed-off-by: Yasin Ustuner [email protected]
Description
Checklist Before Requesting Review