fix(SDHC): Fix SDHC Get Capacity and Implement Get Sectors functionality #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozersa
reviewed
Sep 21, 2023
| @@ -91,10 +91,10 @@ int MXC_SDHC_Lib_SetRCA(void); | |||
| int MXC_SDHC_Lib_GetCSD(mxc_sdhc_csd_regs_t *csd); | |||
|
|
|||
| /* ************************************************************************** */ | |||
| unsigned int MXC_SDHC_Lib_GetCapacity(mxc_sdhc_csd_regs_t* csd); | |||
| unsigned long long MXC_SDHC_Lib_GetCapacity(mxc_sdhc_csd_regs_t* csd); | |||
There was a problem hiding this comment.
Changing function return value might cause some warnings (or error) on existing application that use this library.
But the addition seems simple can be handle easily incase of any warning arise.
ozersa
approved these changes
Sep 21, 2023
Jake-Carter
suggested changes
Sep 21, 2023
karaanil
force-pushed
the
sdhc-capacity-fix
branch
from
c4a6021 to
fac5cdd
Compare
Jake-Carter
approved these changes
Sep 25, 2023
EricB-ADI
pushed a commit
that referenced
this pull request
Nov 21, 2023
…ity (#727) Co-authored-by: Jake Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unsigned int MXC_SDHC_Lib_GetCapacity(mxc_sdhc_csd_regs_t* csd)function returns wrong value.If 32 GB card is inserted to the SD card slot,
MXC_SDHC_Lib_GetCapacityfunction can return at most UINT32_MAX as a result.Therefore, the function prototype is changed to
unsigned long long MXC_SDHC_Lib_GetCapacity(mxc_sdhc_csd_regs_t* csd)to get the correct result.unsigned int MXC_SDHC_Lib_GetSectors(mxc_sdhc_csd_regs_t* csd, int i)function is implemented in sdhc_lib.c file.Checklist Before Requesting Review