Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BLE):Connection updates #804

Closed
wants to merge 71 commits into from
Closed

fix(BLE):Connection updates #804

wants to merge 71 commits into from

Conversation

EricB-ADI
Copy link
Contributor

Pull Request Template

Description

Cordio will now only kill request once connection update attempts are exhausted or connection update aligns with request.

When requesting a connection update request, the app layer will periodically request a connection update based on a timer.
Once a connection update goes through the timer is cancelled. However, this does not discriminate between Master updates and the slave update.

For example, Android immediately request a new connection parameter update. The stack then deletes the request for it's own connection request resulting in connection parameters that are not desired.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

PR Title Guidelines

The MSDK repo follows a custom rule set based on the Conventional Commits standard. The pull request titles will follow this format:

type(scope)<!>: Subject

Types

The list of possible types are:

  1. fix – a bug fix has occurred
  2. feat – a new feature was introduced
  3. chore – changes that do not relate to a fix or feature, or a catch-all type for changes that don’t really fit under any of the other types
  4. refactor – refactored code that neither fixes a bug nor adds a new feature
  5. docs – updates to documentation
  6. style – code styling changes (linter or clang-format)
  7. test – changes involving test code (not changes like deleting a line of code to test if your application works or not)
  8. perf – performance improvements
  9. ci – changes related to continuous integration
  10. build – changes that affect the build system, toolchain, or any other external dependencies
  11. revert – reverts a commit

Appending an ! at the end of the title prefix signifies the PR is a breaking or major change. The <!> is optional in the PR format.

NOTE: The type is case-sensitive and must match one of the listed types.

Scopes

The scopes are dependent on the changes based on their location in the MSDK. The list of possible scopes are:

  1. BLE – Any Bluetooth related changes (i.e. Cordio)
  2. Documentation – Any changes in msdk/Documentation folder
  3. Examples – Any changes in msdk/Examples
  4. Tools – Any changes in msdk/Tools
  5. Boards – Any board file changes
  6. CMSIS – Any CMSIS/Register file changes
  7. MiscDrivers – Any MiscDrivers changes (e.g. TFT Display, PB, LED, External Flash Drivers)
  8. PeriphDrivers – Any changes in msdk/Libraries/PeriphDrivers
  9. ThirdParty – Any third-party library changes (e.g. FreeRTOS, LVGL, lwIP)
  10. MAXUSB – Any MAXUSB changes
  11. SDHC – Any SDHC changes
  12. Build – Any changes involving the build system
  13. ignore – Small and quick miscellaneous fixes (should not be used often)
  14. workflow – Any GitHub workflow-related changes
  15. Other – Any changes that may not fit in the other scopes

NOTE: The scope is case-sensitive and must match one of the listed scopes.

Subject Rules

  1. Use the imperative mood in the Subjects - meaning the tone of the Subject should be like giving an order or request.
  2. The Subject should have useful and concise wording.
  3. The Subject should include what parts are affected in numerical order, if any. Only the parts’ CHIP NAME should be used in the Subject. No die names are allowed.
  4. If the PR title is related to a Jira ticket or an issue, the Subject should begin with the ticket designation.
  5. The first letter must be capitalized and the subject must not end with any punctuation.

More Info

Please refer to the CONTRIBUTING.md for more information regarding the PR Title.

sihyung-maxim and others added 30 commits July 19, 2023 14:50
The workflow can't regenerate register files if it already exists from a prev job
sihyung-maxim and others added 21 commits October 26, 2023 11:05
…#735)

Co-authored-by: Erman Okman <[email protected]>
Co-authored-by: Jake Carter <[email protected]>
Co-authored-by: Jake Carter <[email protected]>
…arget mode functionality (#662)

Co-authored-by: sihyung-maxim <[email protected]>
Co-authored-by: Jake Carter <[email protected]>
Co-authored-by: Jake Carter <[email protected]>
…pped message ordering and other minor fixes (#755)

Co-authored-by: sihyung-maxim <[email protected]>
@github-actions github-actions bot added MAX32655 Related to the MAX32655 (ME17) MAX32665 Related to the MAX32665 (ME14) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) BLE Related to Bluetooth Workflow Related to Workflow development Register Change This issue or pull request involves a change to the MSDK registers. labels Nov 21, 2023
@EricB-ADI EricB-ADI closed this Nov 21, 2023
@EricB-ADI EricB-ADI deleted the fix/conn-updates branch November 22, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE Related to Bluetooth MAX32655 Related to the MAX32655 (ME17) MAX32665 Related to the MAX32665 (ME14) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) Register Change This issue or pull request involves a change to the MSDK registers. Workflow Related to Workflow development
Projects
None yet
Development

Successfully merging this pull request may close these issues.