-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(BLE):Connection updates #804
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow can't regenerate register files if it already exists from a prev job
This reverts commit 2f382d1.
… resolve build warning (#747)
…#735) Co-authored-by: Erman Okman <[email protected]> Co-authored-by: Jake Carter <[email protected]> Co-authored-by: Jake Carter <[email protected]>
…arget mode functionality (#662) Co-authored-by: sihyung-maxim <[email protected]> Co-authored-by: Jake Carter <[email protected]> Co-authored-by: Jake Carter <[email protected]>
…ZE` when calling Ext_Flash_Program_Page() (#748)
… flash functions in SRAM (#756)
…pped message ordering and other minor fixes (#755) Co-authored-by: sihyung-maxim <[email protected]>
… force a watchdog reset to occur (#758)
…8 found in release testing (#759)
… erase functions (#776)
github-actions
bot
added
MAX32655
Related to the MAX32655 (ME17)
MAX32665
Related to the MAX32665 (ME14)
MAX32680
Related to the MAX32680 (ME20)
MAX32690
Related to the MAX32690 (ME18)
BLE
Related to Bluetooth
Workflow
Related to Workflow development
Register Change
This issue or pull request involves a change to the MSDK registers.
labels
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BLE
Related to Bluetooth
MAX32655
Related to the MAX32655 (ME17)
MAX32665
Related to the MAX32665 (ME14)
MAX32680
Related to the MAX32680 (ME20)
MAX32690
Related to the MAX32690 (ME18)
Register Change
This issue or pull request involves a change to the MSDK registers.
Workflow
Related to Workflow development
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Cordio will now only kill request once connection update attempts are exhausted or connection update aligns with request.
When requesting a connection update request, the app layer will periodically request a connection update based on a timer.
Once a connection update goes through the timer is cancelled. However, this does not discriminate between Master updates and the slave update.
For example, Android immediately request a new connection parameter update. The stack then deletes the request for it's own connection request resulting in connection parameters that are not desired.
Checklist Before Requesting Review
PR Title Guidelines
The MSDK repo follows a custom rule set based on the Conventional Commits standard. The pull request titles will follow this format:
type(scope)<!>: Subject
Types
The list of possible types are:
Appending an
!
at the end of the title prefix signifies the PR is a breaking or major change. The <!> is optional in the PR format.NOTE: The type is case-sensitive and must match one of the listed types.
Scopes
The scopes are dependent on the changes based on their location in the MSDK. The list of possible scopes are:
NOTE: The scope is case-sensitive and must match one of the listed scopes.
Subject Rules
More Info
Please refer to the CONTRIBUTING.md for more information regarding the PR Title.