Wip/bl/ad35xxr qspi axi #2407
Open
Wip/bl/ad35xxr qspi axi #2407
+236
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ad354xr using last updated HDL. Signed-off-by: Angelo Dureghello <[email protected]>
Fix default drive strength. Signed-off-by: Angelo Dureghello <[email protected]>
Add support to change axi IO mode between simple SPI, DUAL or QUAD. Signed-off-by: Angelo Dureghello <[email protected]>
Add high speed support for ad354xr using last updated HDL: commit a62f97280e52f923f7a3ec1bae4f799be8420a6d Author: caosjr <[email protected]> Signed-off-by: Angelo Dureghello <[email protected]>
Cleanup reset error flag, so that the error status is clean and ready for new errors. Signed-off-by: Angelo Dureghello <[email protected]>
spectrum70
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
Setting instruction mode for initial configuration operartions, as suggested as safer from HDL team. Streaming mode is actually enabled only for DMA data streaming. Signed-off-by: Angelo Dureghello <[email protected]>
spectrum70
force-pushed
the
wip/bl/ad35xxr-qspi-axi
branch
from
eaf675f to
2fe3c99
Compare
|
Hi all, |
Hi, not related to your modifications. |
amiclaus
reviewed
Jan 13, 2025
| @@ -1417,6 +1442,12 @@ int32_t ad3552r_init(struct ad3552r_desc **desc, | |||
| } | |||
| ldesc->chip_id = param->chip_id; | |||
| ldesc->is_simultaneous = param->is_simultaneous; | |||
| if (ldesc->chip_id == AD3542R_ID || ldesc->chip_id == AD3541R_ID) { | |||
There was a problem hiding this comment.
nit: drop brackets if only one expression is guarded.
Also you swap to a switch case statement. It's easier to extend if new chips are added.
| ret = ad3552r_write_reg(desc, AD3552R_REG_ADDR_STREAM_MODE, loop_len); | ||
| if (ret) | ||
| return ret; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add support for ad354xr in high-speed mode using last HDL provided from Carlos:
commit a62f97280e52f923f7a3ec1bae4f799be8420a6d
Author: caosjr [email protected]
PR Type
PR Checklist