adi:ad5754r: Add initial support #475
Conversation
|
@tfcollins the PR is ready for review now |
test/test_ad5754r.py
Outdated
| @pytest.mark.parametrize("channel", [0]) | ||
| def test_ad5754r_tx_data(test_dma_tx, iio_uri, classname, channel): | ||
| # TODO add function call once driver is updated with waveform generation | ||
| # capabilities |
There was a problem hiding this comment.
Need to wait for the driver to make sure this actually works. Can you enhance this test code to include the other properties as well? We are trying to increase general test coverage
There was a problem hiding this comment.
I've removed this for now, and have added other attribute tests.
There was a problem hiding this comment.
@tfcollins Is there a way to test string properties of the channel class? I can see existing test methods for integer properties of channel classes, but not for non-integer ones.
There was a problem hiding this comment.
You would need to enhance the attribute_single_value_str function to support sub-channels
Add initial attribute r/w support for ad5754r Signed-off-by: RibhuDP <[email protected]>
|
Hi @tfcollins , I've now added tests for global and channel attributes. Could you please have a look? |
Description
Add initial attribute r/w support for ad5754r
Add driver, example, doc and emulation context for ad5754r
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
SDP-K1 with EVAL-AD5754R, on a Windows 10 machine
Performed attribute read/write
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: