Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adi/rx_tx.py: fix return type of rx_enabled_channels #480

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

dlech
Copy link
Collaborator

@dlech dlech commented Oct 4, 2023

Description

As mentioned in the doc string and in the setter type hints, rx_enabled_channels can be either a list of channel numbers (int) or names (str).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • OS:

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

As mentioned in the doc string and in the setter type hints,
`rx_enabled_channels` can be either a list of channel numbers (int)
or names (str).

Signed-off-by: David Lechner <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Generated documentation for this PR is available at Link

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Unit Test Results

1 245 tests  ±0   247 ✔️ ±0   5m 13s ⏱️ +4s
       1 suites ±0   998 💤 ±0 
       1 files   ±0       0 ±0 

Results for commit b7adaa1. ± Comparison against base commit bdc6fa2.

♻️ This comment has been updated with latest results.

@tfcollins tfcollins merged commit f2abbd5 into master Oct 4, 2023
44 checks passed
@tfcollins tfcollins deleted the dlech/fix-rx_enabled_channels-return-type branch October 4, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants