Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adi/ad2s1210: add AD2S1210 Resolver-to-Digital Converter #481

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

dlech
Copy link
Collaborator

@dlech dlech commented Oct 4, 2023

Description

This adds support for the AD2S1210 Resolver-to-Digital Converter.

The IIO ABI is based on work that is currently being mainlined and is not compatible with the older driver in staging.

Not all features are supported yet since libiio does not support iio events. This means that the AD2S1210's fault detection and threshold configuration is not supported.

The tests are passing when run on real hardware.

Fixes #455

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

On the ZedBoard to set up a trigger for the buffer:

mkdir /sys/kernel/config/iio/triggers/hrtimer/test
iio_readdev ad2s1210 -t test -s 1000 -T 1000 | hd
iio_attr -d test sampling_frequency 100000

Then on the remote computer:

pytest test/test_ad2s1210.py --uri=ip:10.2.5.203

Test Configuration:

  • Hardware: EVAL-AD2S1210 + ZedBoard
  • OS: Kuiper GNU/Linux 11.2 (bullseye) with kernel from iio/testing

Documentation

https://analogdevicesinc.github.io/pyadi-iio/prs/dlech/ad2s1210/devices/adi.ad2s1210.html

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Unit Test Results

1 251 tests  +6      250 ✔️ +3   5m 9s ⏱️ ±0s
       1 suites ±0   1 001 💤 +3 
       1 files   ±0          0 ±0 

Results for commit a09c520. ± Comparison against base commit bdc6fa2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Generated documentation for this PR is available at Link

@pamolloy pamolloy added this to the BayLibre September Delivery milestone Oct 4, 2023
@dlech dlech force-pushed the dlech/ad2s1210 branch 3 times, most recently from ef40214 to 5fa7623 Compare October 4, 2023 23:18
This adds support for the AD2S1210 Resolver-to-Digital Converter.

The IIO ABI is based on work that is currently being mainlined and
is not compatible with the older driver in staging.

Not all features are supported yet since libiio does not support iio
events. This means that the AD2S1210's fault detection and threshold
configuration is not supported.

The tests are passing when run on real hardware.

Signed-off-by: David Lechner <[email protected]>
@tfcollins tfcollins merged commit 339a77a into master Oct 26, 2023
44 checks passed
@tfcollins tfcollins deleted the dlech/ad2s1210 branch October 26, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AD2S1210
3 participants