Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ad3552r #564

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

spectrum70
Copy link
Contributor

Add ad3552r driver, test script, example code, rst file and emu xml.

Tested:

  • pytest
  • invoke precommit
  • pre-commit run --all-files
  • executed sample on target

All tests passed.

Reviewed-by: Trevor Gamblin [email protected]

Description

Add support for ad3552r

Type of change

Please delete options that are not relevant.

  • [x ] New feature (non-breaking change which adds functionality)
  • [x ] This change requires a documentation update

How has this been tested?

pytest -v --hw=ad3552r --emu --emu-xml=/home/angelo/dev-baylibre/adi/pyadi-iio/test/emu/devices/ad3552r.xml
test/test_ad3552r.py::test_ad3552r_raw_attr[raw-0-4000-1000-1-3-voltage0-adi.ad3552r] PASSED
test/test_ad3552r.py::test_ad3552r_raw_attr[raw-0-4000-1000-1-3-voltage1-adi.ad3552r] PASSED

invoke precommit
Running supported_parts check
No parts missing from supported_parts.md

pre-commit run --all-files
codespell................................................................Passed
isort....................................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Debug Statements (Python)................................................Passed
Check docstring is first.................................................Passed
Flake8...................................................................Passed
black....................................................................Passed
blacken-docs.............................................................Passed
Insert license in comments...............................................Passed

example executed on target

Test Configuration:

  • Hardware: Arch Linux, 6.5.0-rc2-devel-00345-gc2782531397f
  • OS: Linux

Documentation

rst files has been added accordingly

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have signed off all commits and they contain "Signed-off by: "
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

adi/ad3552r.py Outdated Show resolved Hide resolved
@spectrum70 spectrum70 force-pushed the wip/bl/ad3552r branch 2 times, most recently from f2a89fd to 663f272 Compare May 21, 2024 14:38
@spectrum70 spectrum70 marked this pull request as ready for review May 21, 2024 14:41
@spectrum70 spectrum70 requested a review from tfcollins May 21, 2024 14:42
@spectrum70
Copy link
Contributor Author

Hi @tfcollins

fixed above points and re-run all above tests. All passed.

@spectrum70
Copy link
Contributor Author

Hi @tfcollins ,
not clear how the PR acceptance process works, i don't see any reviewer assigned here, can you help me ?

adi/ad3552r.py Outdated

_complex_data = False
_device_name = "AD3552R"
channels = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused now. Is that expected? Not sure if this is just a name miss-match between channel and channels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tfcollins ,

fixed that, thanks.
Pushed a new version.

@spectrum70 spectrum70 force-pushed the wip/bl/ad3552r branch 2 times, most recently from 7e8579c to 4f091d0 Compare June 6, 2024 15:31
Add ad3552r driver, test script, example code, rst file and emu xml.

Tested:
- pytest
- invoke precommit
- pre-commit run --all-files
- executed sample on target

All tests passed.

Signed-off-by: Angelo Dureghello <[email protected]>
Reviewed-by: Trevor Gamblin <[email protected]>
@spectrum70
Copy link
Contributor Author

fixed conflicts with main

@tfcollins tfcollins merged commit 16fe567 into analogdevicesinc:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants