-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for ad3552r #564
Conversation
f2a89fd
to
663f272
Compare
Hi @tfcollins fixed above points and re-run all above tests. All passed. |
Hi @tfcollins , |
adi/ad3552r.py
Outdated
|
||
_complex_data = False | ||
_device_name = "AD3552R" | ||
channels = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused now. Is that expected? Not sure if this is just a name miss-match between channel and channels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tfcollins ,
fixed that, thanks.
Pushed a new version.
7e8579c
to
4f091d0
Compare
Add ad3552r driver, test script, example code, rst file and emu xml. Tested: - pytest - invoke precommit - pre-commit run --all-files - executed sample on target All tests passed. Signed-off-by: Angelo Dureghello <[email protected]> Reviewed-by: Trevor Gamblin <[email protected]>
4f091d0
to
8ff271a
Compare
fixed conflicts with main |
Add ad3552r driver, test script, example code, rst file and emu xml.
Tested:
All tests passed.
Reviewed-by: Trevor Gamblin [email protected]
Description
Add support for ad3552r
Type of change
Please delete options that are not relevant.
How has this been tested?
pytest -v --hw=ad3552r --emu --emu-xml=/home/angelo/dev-baylibre/adi/pyadi-iio/test/emu/devices/ad3552r.xml
test/test_ad3552r.py::test_ad3552r_raw_attr[raw-0-4000-1000-1-3-voltage0-adi.ad3552r] PASSED
test/test_ad3552r.py::test_ad3552r_raw_attr[raw-0-4000-1000-1-3-voltage1-adi.ad3552r] PASSED
invoke precommit
Running supported_parts check
No parts missing from supported_parts.md
pre-commit run --all-files
codespell................................................................Passed
isort....................................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Debug Statements (Python)................................................Passed
Check docstring is first.................................................Passed
Flake8...................................................................Passed
black....................................................................Passed
blacken-docs.............................................................Passed
Insert license in comments...............................................Passed
example executed on target
Test Configuration:
Documentation
rst files has been added accordingly
Checklist: