Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cn0511 test #574

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Fix cn0511 test #574

merged 3 commits into from
Jun 13, 2024

Conversation

trishaange01
Copy link
Contributor

@trishaange01 trishaange01 commented Jun 7, 2024

Description

This PR includes changes in test_cn0511_attr, from test_cn0511_p.py module, to fix the failing tests. The issue was caused by setting values that do not match the type of the parameter. It replaces the param_set parameter with repeats since it corresponds to the parameter name defined in the attribute test used, test_attribute_single_value. It moves the test for frequency into the added test case, test_cn0511_attr_with_depends, which includes a params argument to set sample_rate value before setting frequency value.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware: cn0511
  • OS: Windows

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@trishaange01 trishaange01 changed the base branch from cn0511 to main June 7, 2024 03:52
@trishaange01
Copy link
Contributor Author

Hi @tfcollins. This PR is ready for review. Thanks! :)

@tfcollins tfcollins merged commit 165ff17 into analogdevicesinc:main Jun 13, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants