adi:ad4170: Add support for ad4170 #579
Merged
+144
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansunil
force-pushed
the
add-support-to-ad4170
branch
4 times, most recently
from
a117d2a to
e1436bd
Compare
|
Changelog: Fixed pylint and build errors |
|
@tfcollins - Could you please review these changes when you get a chance? |
tfcollins
reviewed
Jun 20, 2024
| """ AD4170 ADC """ | ||
|
|
||
| _complex_data = False | ||
| channels = [] # type: ignore |
There was a problem hiding this comment.
This needs to be defined or reset (set to []) in the constructor. Otherwise you cannot use multiple instances of this class in the same session.
tfcollins
reviewed
Jun 20, 2024
adi/ad4170.py
Outdated
| self._set_iio_attr(self.name, "scale", False, str(Decimal(value).real)) | ||
|
|
||
| def to_volts(self, index, val): | ||
| """Converts raw value to SI""" |
There was a problem hiding this comment.
Inputs need documentation
tfcollins
requested changes
Jun 20, 2024
jansunil
force-pushed
the
add-support-to-ad4170
branch
2 times, most recently
from
fc15a70 to
8145d5b
Compare
|
Changelog: Addressed review comments
|
|
@tfcollins - Do these changes look good now? |
tfcollins
reviewed
Jun 24, 2024
adi/ad4170.py
Outdated
Comment on lines
7
to
35
| # | ||
| # Redistribution and use in source and binary forms, with or without modification, | ||
| # are permitted provided that the following conditions are met: | ||
| # - Redistributions of source code must retain the above copyright | ||
| # notice, this list of conditions and the following disclaimer. | ||
| # - Redistributions in binary form must reproduce the above copyright | ||
| # notice, this list of conditions and the following disclaimer in | ||
| # the documentation and/or other materials provided with the | ||
| # distribution. | ||
| # - Neither the name of Analog Devices, Inc. nor the names of its | ||
| # contributors may be used to endorse or promote products derived | ||
| # from this software without specific prior written permission. | ||
| # - The use of this software may or may not infringe the patent rights | ||
| # of one or more patent holders. This license does not release you | ||
| # from the requirement that you obtain separate licenses from these | ||
| # patent holders to use this software. | ||
| # - Use of the software either in source or binary form, must be run | ||
| # on or directly connected to an Analog Devices Inc. component. | ||
| # | ||
| # THIS SOFTWARE IS PROVIDED BY ANALOG DEVICES "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, | ||
| # INCLUDING, BUT NOT LIMITED TO, NON-INFRINGEMENT, MERCHANTABILITY AND FITNESS FOR A | ||
| # PARTICULAR PURPOSE ARE DISCLAIMED. | ||
| # | ||
| # IN NO EVENT SHALL ANALOG DEVICES BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
| # EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, INTELLECTUAL PROPERTY | ||
| # RIGHTS, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR | ||
| # BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
| # STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF | ||
| # THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
There was a problem hiding this comment.
Sorry missed this the first time. This long form license can be removed. Just need the SPDX line
tfcollins
requested changes
Jun 24, 2024
1. Add pyadi driver for ad4170 family 2. Add example script for data capture with ad4170 3. Add documentation Signed-off-by: Janani Sunil <[email protected]>
jansunil
force-pushed
the
add-support-to-ad4170
branch
from
8145d5b to
3e95767
Compare
|
Changelog: Address review comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: