Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adi:ad4630.py: fix rx #580

Merged
merged 1 commit into from
Jun 17, 2024
Merged

adi:ad4630.py: fix rx #580

merged 1 commit into from
Jun 17, 2024

Conversation

cristina-suteu
Copy link
Contributor

Description

Fixes #534 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • OS:

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Cristina Suteu <[email protected]>
@cristina-suteu cristina-suteu requested a review from tfcollins June 14, 2024 10:15
Copy link

Generated documentation for this PR is available at Link

Copy link

Test Results

1 588 tests  ±0     348 ✅ ±0   11m 40s ⏱️ -6s
    1 suites ±0   1 240 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 6780466. ± Comparison against base commit a004772.

Copy link

github-actions bot commented Jun 14, 2024

Test Results

1 588 tests  ±0     348 ✅ ±0   11m 47s ⏱️ -1s
    1 suites ±0   1 240 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 6780466. ± Comparison against base commit a004772.

♻️ This comment has been updated with latest results.

@tfcollins tfcollins merged commit 3824cc2 into main Jun 17, 2024
54 checks passed
@tfcollins tfcollins deleted the fix-4630-rx branch June 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ad4630 fails dma_rx test
2 participants