-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adi/ad7625: add support for AD762x/AD796x #609
base: main
Are you sure you want to change the base?
Conversation
|
||
_device_name = "" | ||
_complex_data = False | ||
_rx_channel_names = ["voltage0-voltage1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this channel correct? Seems odd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a differential antiphase pair of inputs making up the channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this PR is fine. Just had the question on the channel name(s). Please fix the lint issue. You can ignore the doc link error w.r.t. ez.analog.com
@tfcollins by lint issue, do you mean this?
|
There was an upstream error that go resolved outside of github. This here needs to be fixed. Each class needs a doc page |
Should be fixed now. Also rebased on top of latest main branch. |
Signed-off-by: Trevor Gamblin <[email protected]>
Rebased on top of latest main. |
Description
Add basic support for the AD7625, AD7626, AD7960, and AD7961 ADCs in pyadi-iio. The corresponding driver will be merged in kernel v6.13 and backported to the ADI kernel tree shortly after, so we may not actually want to merge this just yet, but it should be sufficient to review. The driver is available in the
iio
kernel tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=togregType of change
How has this been tested?
Tested against Zedboard with e.g.:
pytest -v --hw=ad7625 --uri=ip:192.168.40.140 test/test_ad7625.py
and via emulation with:
pytest -v --hw=ad7625 --emu --emu-xml=test/emu/devices/ad7625.xml test/test_ad7625.py
Test Configuration:
Documentation
Documentation added in doc/source/devices/adi.ad7625.rst
Checklist: