Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adis16550 and adis16550w #610

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

rbudai98
Copy link
Contributor

Description

Added support for adis16550 and adis16550W

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Test Configuration:

  • Hardware: Rpi4 + ADIS16550W
  • OS: Kuiper, RPi-6.1

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@rbudai98 rbudai98 requested review from tfcollins and buha October 21, 2024 12:18
Copy link

github-actions bot commented Oct 21, 2024

Test Results

1 632 tests  +20     365 ✅ + 1   11m 55s ⏱️ +4s
    1 suites ± 0   1 267 💤 +19 
    1 files   ± 0       0 ❌ ± 0 

Results for commit ac2e3da. ± Comparison against base commit 67bba95.

♻️ This comment has been updated with latest results.

@rbudai98 rbudai98 force-pushed the adis16550_add_support branch 2 times, most recently from aa11165 to 41bb5f8 Compare October 21, 2024 12:49
@rbudai98
Copy link
Contributor Author

v2:

  • removed unused import
  • addressed black format issues

@rbudai98 rbudai98 force-pushed the adis16550_add_support branch 2 times, most recently from 8513ad6 to 30519a3 Compare October 21, 2024 13:06
Copy link

Generated documentation for this PR is available at Link

@rbudai98 rbudai98 force-pushed the adis16550_add_support branch from 30519a3 to 3da7798 Compare October 25, 2024 13:14
@rbudai98 rbudai98 force-pushed the adis16550_add_support branch from 3da7798 to ac2e3da Compare October 25, 2024 13:17
@tfcollins tfcollins merged commit dde58ee into main Oct 28, 2024
52 of 54 checks passed
@tfcollins tfcollins deleted the adis16550_add_support branch October 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants