Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AD9084 Side B FPGA data interfaces #613

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

tfcollins
Copy link
Collaborator

@tfcollins tfcollins commented Nov 1, 2024

Description

PR adds methods to access AD9084 side B FPGA interfaces (DMA, DDS). This includes tests and example context from ADSY1100.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • AD9084 emulation tests

Test Configuration:

  • Hardware: AD9084 emulation
  • OS: Ubuntu 22.04

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tfcollins tfcollins added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 1, 2024
@tfcollins tfcollins requested a review from mhennerich November 1, 2024 16:36
@tfcollins tfcollins self-assigned this Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Generated documentation for this PR is available at Link

Copy link

github-actions bot commented Nov 1, 2024

Test Results

1 637 tests  +5     346 ✅  - 19   11m 55s ⏱️ +2s
    1 suites ±0   1 267 💤 ± 0 
    1 files   ±0      24 ❌ +24 

For more details on these failures, see this check.

Results for commit 9a63a61. ± Comparison against base commit 58c3827.

Copy link

github-actions bot commented Nov 1, 2024

Test Results

1 631 tests   - 1     364 ✅  - 1   11m 53s ⏱️ ±0s
    1 suites ±0   1 267 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e7acf21. ± Comparison against base commit 58c3827.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@mhennerich mhennerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tfcollins tfcollins merged commit 5915e4b into main Nov 12, 2024
52 of 54 checks passed
@tfcollins tfcollins deleted the tfcollins/ad9084-split branch November 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants