Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track card test cases #2

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Track card test cases #2

merged 10 commits into from
Mar 4, 2024

Conversation

anasnadeemws
Copy link
Owner

Ticket Link


Related Links


Description


Steps to Reproduce / Test



Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

GIF's


Live Link


Copy link

@poojesh-ws poojesh-ws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. These are minor changes. Also one suggestion. After raising a pr, always self review once. This helps out in cross checking if the changes you raised are correct and rectify any unwanted typos that may be present

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unused variable that is showing up in the review changes. Kindly fix those

@@ -1,7 +1,7 @@
/**
*
* Tests for TrackCard
*
*s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this typo here

@anasnadeemws anasnadeemws merged commit 13b9631 into master Mar 4, 2024
0 of 3 checks passed
@anasnadeemws anasnadeemws deleted the track-card-testcase branch March 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants