Fixed bug in FeatureModelEditPolicy.

* was possible to invoke GroupFeaturesCommand on orphaned features.
anb0s · Feb 1, 2013 · 5a6412a · 5a6412a
1 parent 9fa5685
commit 5a6412a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...yafmt.ui.editors.fm/src/cz/jpikl/yafmt/ui/editors/fm/policies/FeatureModelEditPolicy.java b/...yafmt.ui.editors.fm/src/cz/jpikl/yafmt/ui/editors/fm/policies/FeatureModelEditPolicy.java
@@ -47,10 +47,10 @@ private Command createGroupFeaturesCommand(List<?> selectedEditParts, boolean xo
         EObject commonParent = null;
         for(Feature feature: features) {
             EObject parent = feature.getParent();
-            if(parent == null)
-                return null;
             if(parent instanceof Group)
                 parent = ((Group) parent).getParent();
+            if(!(parent instanceof Feature))
+                return null;
             if(commonParent == null)
                 commonParent = parent;
             else if(parent != commonParent)