Fix compilation on kernels >= 5.1 #19

ghost · 2019-05-12T03:49:48Z

Based on torvalds/linux@e19f70a. Fixes #17.

EHfive · 2019-05-17T03:05:32Z

@morphis Could you please give a review

SoulInfernoDE · 2019-05-23T17:55:55Z

DKMS make.log for anbox-binder-1 for kernel 5.1.4-050104-generic (x86_64)
Do 23. Mai 19:52:55 CEST 2019
make -C /lib/modules/5.1.4-050104-generic/build V=0 M=$PWD
make[1]: Verzeichnis „/usr/src/linux-headers-5.1.4-050104-generic“ wird betreten
  CC [M]  /var/lib/dkms/anbox-binder/1/build/deps.o
  CC [M]  /var/lib/dkms/anbox-binder/1/build/binder.o
/var/lib/dkms/anbox-binder/1/build/binder.c:3406:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .fault = binder_vm_fault,
           ^~~~~~~~~~~~~~~
/var/lib/dkms/anbox-binder/1/build/binder.c:3406:11: note: (near initialization for ‘binder_vm_ops.fault’)
cc1: some warnings being treated as errors
scripts/Makefile.build:275: recipe for target '/var/lib/dkms/anbox-binder/1/build/binder.o' failed
make[2]: *** [/var/lib/dkms/anbox-binder/1/build/binder.o] Error 1
Makefile:1571: recipe for target '_module_/var/lib/dkms/anbox-binder/1/build' failed
make[1]: *** [_module_/var/lib/dkms/anbox-binder/1/build] Error 2
make[1]: Verzeichnis „/usr/src/linux-headers-5.1.4-050104-generic“ wird verlassen
Makefile:8: recipe for target 'all' failed
make: *** [all] Error 2

ghost · 2019-05-24T02:25:11Z

@SoulInfernoDE
Please check if you have patched the source code before compilation. I have no issues compiling the modules on 5.1.4 after the patch.

GrigorijST · 2019-05-24T11:54:45Z

@SoulInfernoDE
Please check if you have patched the source code before compilation. I have no issues compiling the modules on 5.1.4 after the patch.

I can confirm it. Everything is good on 5.1.4 after the patch...

SoulInfernoDE · 2019-05-25T19:21:47Z

yes with the patch it works - is this patch beeing merged somehow somewhere or do we always need to apply this everytime on kernel 5.x ?

WhyNotHugo · 2019-05-27T08:58:32Z

@SoulInfernoDE Once this PR is merged, you won't have to apply the patch manually any more.

dreamcat4 · 2019-06-03T09:49:45Z

@anbox please take the patch

binder/binder.c

ghost · 2019-06-04T07:04:47Z

@morphis
It looks like a retpoline compiler is needed - should we use GCC 8 for Travis?

Traneptora · 2019-06-05T23:22:22Z

Apparently I did a bunch of work on this, only to discover my work is a duplicate of this PR... although I did discover that apparently, the header change should start at kernel 4.17, which is when the typedef for vm_fault_t was added to the kernel headers.

Mhowser · 2019-06-09T06:52:28Z

Any progress on getting this merged?

SoulInfernoDE · 2019-06-16T16:46:45Z

if you need to apply patch you can look at:
https://github.com/archlinuxcn/repo/blob/b668ee4ea9749c77c55212032c5f064d6fb11107/archlinuxcn/anbox-git/fix_linux_5.1.x.patch

This was referenced here also. On debian/linux mint you need to sudo apt install patch. Then download the source code that needs to be patched. Put the patchfile in the root of the source code folder and use terminal/shell to apply the patch:
patch -p1 < fix_linux_5.1.x.patch
Then build the module again from the patched source.

Lumumba · 2019-06-16T17:08:18Z

i managed to do it but thank you Am So., 16. Juni 2019 um 18:46 Uhr schrieb Soul Inferno DE < [email protected]>:

…

if you need to apply patch you can look at: https://github.com/archlinuxcn/repo/blob/b668ee4ea9749c77c55212032c5f064d6fb11107/archlinuxcn/anbox-git/fix_linux_5.1.x.patch This was referenced here also. On debian/linux mint you need to sudo apt install patch. Then download the source code that needs to be patched. Put the patchfile in the root of the source code folder and use terminal/shall to apply the patch: patch -p1 < fix_linux_5.1.x.patch Then build the module again from the patched source. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#19?email_source=notifications&email_token=AD4VHI74LIWX5OXM3CQ5GSDP2ZU7NA5CNFSM4HMJPRN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZQZEQ#issuecomment-502467730>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD4VHI4ZYRDRQA36OZXALHTP2ZU7NANCNFSM4HMJPRNQ> .

morphis · 2019-06-19T04:58:33Z

@86423355844265459587182778 if we can use gcc8 on travis just for the relevant kernels that would be the way to go.

Technically-Alexander · 2019-06-30T04:30:19Z

Thanks @86423355844265459587182778, this tweak worked for me to install the binder on Fedora 30 running 5.1.15-300 kernel.

Hopefully the team implements it soon, and doesn't break anything. Good work. Appreciate it.

ghost · 2019-06-30T05:08:13Z

@Technically-Alexander
You are welcome. I do not know how to update the Travis build configuration to make Travis use GCC 8 just for kernels >= 5.0, so any help would be greatly appreciated.

Hattshire · 2019-07-04T06:42:36Z

@Technically-Alexander
You are welcome. I do not know how to update the Travis build configuration to make Travis use GCC 8 just for kernels >= 5.0, so any help would be greatly appreciated.

Here are some details about it:
https://docs.travis-ci.com/user/languages/cpp/#c11c11-and-beyond-and-toolchain-versioning

Hattshire

Add to `apt:`

apt:
  sources:
    - ubuntu-toolchain-r-test
  packages:
    - g++-8

At:

anbox-modules/.travis.yml

Lines 6 to 12 in ec5b60a

    
           apt: 
        
             packages: 
        
               - bison 
        
               - flex 
        
               - libelf-dev 
        
               - dpkg-dev 
        
               - debhelper

Change `KVER=5.1` and `KVER=5.0`

To:

- KVER=5.0 && CC=gcc-8 && CXX=g++-8
- KVER=5.1 && CC=gcc-8 && CXX=g++-8

At:

anbox-modules/.travis.yml

Lines 24 to 28 in ec5b60a

    
           - KVER=4.17 
        
           - KVER=5.0 
        
           - KVER=5.1 
        
           - KVER=master

Hattshire · 2019-07-04T08:17:54Z

This problem with the travis build rises from the mitigation of SPECTREv2, released on KVER=4.20, backported to 4.19.2, so builds to kernel versions equal or greater also will fail with an outdated compiler.

However, travis is not testing against them, sooo whatever, I guess

https://stackoverflow.com/questions/48089426/what-is-a-retpoline-and-how-does-it-work
https://lkml.org/lkml/2018/10/23/469

Hattshire · 2019-07-04T09:58:15Z

Just checked kernel's makefile:
https://github.com/torvalds/linux/blob/550d1f5bda33fa3b203d8cf8df1396825dbfd213/Makefile#L410
I wonder if it's taking CC as that 🤔

ghost · 2019-07-04T10:12:02Z

I managed to make Travis use GCC 8 just for kernels >= 5.0. Thanks @Hattshire!

morphis

LGTM

TheOneWithTheBraid · 2019-08-06T14:25:30Z

@morphis When will you update the Packages in your PPA at https://launchpad.net/~morphis/+archive/ubuntu/anbox-support/+packages ?

hosford42 · 2020-04-27T20:24:20Z

I'm still getting this error.

/var/lib/dkms/anbox/1/build/binder/binder.c:3382:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .fault = binder_vm_fault,
           ^~~~~~~~~~~~~~~
/var/lib/dkms/anbox/1/build/binder/binder.c:3382:11: note: (near initialization for ‘binder_vm_ops.fault’)
cc1: some warnings being treated as errors
scripts/Makefile.build:288: recipe for target '/var/lib/dkms/anbox/1/build/binder/binder.o' failed
make[2]: *** [/var/lib/dkms/anbox/1/build/binder/binder.o] Error 1
Makefile:1655: recipe for target '_module_/var/lib/dkms/anbox/1/build/binder' failed

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.4 LTS
Release:	18.04
Codename:	bionic

$ uname -r
5.3.0-46-generic

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.5.0-3ubuntu1~18.04' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)

Please let me know if there's other information I can provide to help.

TheOneWithTheBraid · 2020-04-28T06:39:30Z

@hosford42 I guess you have installed linux-headers and are building from latest upstream?

TheOneWithTheBraid · 2020-04-28T06:40:59Z

@hosford42 Oh, sorry, maybe #36 might fix this?

hosford42 · 2020-04-29T02:39:27Z

That does look like it will address my error. I was attempting to follow the instructions in https://github.com/anbox/anbox/blob/master/docs/install.md, which indicate that anbox-modules should be installed from ppa:morphis/anbox-support.

Fix compilation on kernels >= 5.1

ae35b8d

This was referenced May 12, 2019

unable to install the modules on armhf #18

Closed

DKMS Binder Failed Linux Kernel 5.1 anbox/anbox#1130

Open

THMonster mentioned this pull request May 17, 2019

Anbox-module 在5.1内核中dkms无法通过编译 archlinuxcn/repo#1179

Closed

MarvelousBlack referenced this pull request in archlinuxcn/repo May 24, 2019

Repair anbox-git

3cc0566

ghost mentioned this pull request May 27, 2019

Updated binder.c to compile against Kernel 5.0+. #22

Closed

morphis suggested changes Jun 4, 2019

View reviewed changes

binder/binder.c Show resolved Hide resolved

Add KVER=5.0 and KVER=5.1 to travis configuration

ec5b60a

ghost mentioned this pull request Jun 5, 2019

Anbox-modules-dkms don't compile Linux 5.1 kernel anbox/anbox#1155

Closed

Hattshire suggested changes Jul 4, 2019

View reviewed changes

SoulInfernoDE mentioned this pull request Jul 4, 2019

binder modules fails to build #21

Closed

Anonymous added 2 commits July 4, 2019 18:37

Update Travis configuration to use GCC 8

c0518e9

Update Travis configuration

0b96354

Update Travis configuration

2dc5e2e

Update Travis configuration

85d3854

mrkmg mentioned this pull request Jul 12, 2019

Fix type of vm_fault_t in binder.c #25

Closed

morphis approved these changes Jul 13, 2019

View reviewed changes

morphis merged commit 816dd4d into anbox:master Jul 13, 2019

morphis mentioned this pull request Jul 29, 2019

binder.c: Use vm_fault_t for newer kernel headers #23

Closed

bentolor mentioned this pull request Oct 29, 2019

Add KVER=5.2 and KVER=5.3 to travis configuration #38

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compilation on kernels >= 5.1 #19

Fix compilation on kernels >= 5.1 #19

ghost commented May 12, 2019

EHfive commented May 17, 2019

SoulInfernoDE commented May 23, 2019

ghost commented May 24, 2019

GrigorijST commented May 24, 2019

SoulInfernoDE commented May 25, 2019 •

edited

Loading

WhyNotHugo commented May 27, 2019

dreamcat4 commented Jun 3, 2019

ghost commented Jun 4, 2019

Traneptora commented Jun 5, 2019 •

edited

Loading

Mhowser commented Jun 9, 2019

SoulInfernoDE commented Jun 16, 2019 •

edited

Loading

Lumumba commented Jun 16, 2019 via email

morphis commented Jun 19, 2019

Technically-Alexander commented Jun 30, 2019

ghost commented Jun 30, 2019

Hattshire commented Jul 4, 2019

Hattshire left a comment •

edited

Loading

Hattshire commented Jul 4, 2019

Hattshire commented Jul 4, 2019

ghost commented Jul 4, 2019

morphis left a comment

TheOneWithTheBraid commented Aug 6, 2019

hosford42 commented Apr 27, 2020

TheOneWithTheBraid commented Apr 28, 2020

TheOneWithTheBraid commented Apr 28, 2020

hosford42 commented Apr 29, 2020

Fix compilation on kernels >= 5.1 #19

Fix compilation on kernels >= 5.1 #19

Conversation

ghost commented May 12, 2019

EHfive commented May 17, 2019

SoulInfernoDE commented May 23, 2019

ghost commented May 24, 2019

GrigorijST commented May 24, 2019

SoulInfernoDE commented May 25, 2019 • edited Loading

WhyNotHugo commented May 27, 2019

dreamcat4 commented Jun 3, 2019

ghost commented Jun 4, 2019

Traneptora commented Jun 5, 2019 • edited Loading

Mhowser commented Jun 9, 2019

SoulInfernoDE commented Jun 16, 2019 • edited Loading

Lumumba commented Jun 16, 2019 via email

morphis commented Jun 19, 2019

Technically-Alexander commented Jun 30, 2019

ghost commented Jun 30, 2019

Hattshire commented Jul 4, 2019

Hattshire left a comment • edited Loading

Choose a reason for hiding this comment

Add to apt:

At:

Change KVER=5.1 and KVER=5.0

To:

At:

Hattshire commented Jul 4, 2019

Hattshire commented Jul 4, 2019

ghost commented Jul 4, 2019

morphis left a comment

Choose a reason for hiding this comment

TheOneWithTheBraid commented Aug 6, 2019

hosford42 commented Apr 27, 2020

TheOneWithTheBraid commented Apr 28, 2020

TheOneWithTheBraid commented Apr 28, 2020

hosford42 commented Apr 29, 2020

SoulInfernoDE commented May 25, 2019 •

edited

Loading

Traneptora commented Jun 5, 2019 •

edited

Loading

SoulInfernoDE commented Jun 16, 2019 •

edited

Loading

Hattshire left a comment •

edited

Loading

Add to `apt:`

Change `KVER=5.1` and `KVER=5.0`