Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB v6 support to grype-db / grype-db-manager #446

Merged
merged 29 commits into from
Jan 23, 2025
Merged

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Dec 2, 2024

Adjusts the grype-db-manager to be DB-v6 aware. This also pays down some tech debt by translating the CLI test hardness for the manager to use pytest over the golang bash test harness.

PR stack:

  1. Add release ID to OS models #457
  2. Pull in more v6 schema changes #456
  3. Enable packaging v6 DBs #437
  4. Add transformers for v6 DB schema #436

@wagoodman

This comment was marked as outdated.

@wagoodman wagoodman force-pushed the update-package-for-v6 branch from 25d1b8a to 1a79f18 Compare December 4, 2024 21:27
Base automatically changed from update-package-for-v6 to main December 4, 2024 22:16
@wagoodman wagoodman force-pushed the add-v6-to-manager branch 3 times, most recently from 0ee085d to 48566af Compare December 17, 2024 14:04
@wagoodman wagoodman changed the base branch from main to v6-enhancements December 20, 2024 15:03
@wagoodman wagoodman force-pushed the v6-enhancements branch 2 times, most recently from e444a5a to ddfa068 Compare December 20, 2024 16:11
Base automatically changed from v6-enhancements to main December 20, 2024 16:35
@wagoodman wagoodman force-pushed the add-v6-to-manager branch 2 times, most recently from 0d4a2fd to 2a581d8 Compare December 24, 2024 02:40
Comment on lines 28 to 31
{
"schema": "6",
"grype-version": "feat/v6-query-api",
"supported": false

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current plan is to merge this with the dev branch + supported = true

Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

manager/src/grype_db_manager/db/latest.py Show resolved Hide resolved
@wagoodman wagoodman marked this pull request as draft January 21, 2025 18:13
@wagoodman
Copy link
Contributor Author

I need to understand why the DB build times are so high before this can be merged

@wagoodman wagoodman marked this pull request as ready for review January 23, 2025 19:10
@wagoodman wagoodman marked this pull request as draft January 23, 2025 19:10
@wagoodman
Copy link
Contributor Author

Should not be merged until anchore/grype#2394 is merged and this is pointing back at the main branch

@wagoodman wagoodman marked this pull request as ready for review January 23, 2025 19:16
@wagoodman wagoodman enabled auto-merge (squash) January 23, 2025 19:16
@wagoodman wagoodman disabled auto-merge January 23, 2025 19:17
@wagoodman wagoodman enabled auto-merge (squash) January 23, 2025 19:41
@wagoodman wagoodman merged commit 48d5802 into main Jan 23, 2025
12 checks passed
@wagoodman wagoodman deleted the add-v6-to-manager branch January 23, 2025 19:44
@wagoodman wagoodman added changelog-ignore Don't consider when generating the changelog and removed changelog-ignore Don't consider when generating the changelog labels Jan 23, 2025
@wagoodman wagoodman changed the title Add DB v6 support to grype-db-manager Add DB v6 support to grype-db / grype-db-manager Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants