Fix DB v6 curator directory creation #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
added
the
changelog-ignore
wagoodman
changed the title
spiffcs
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
👍 - I saw that the curator_test was updated to cover some of the replace behavior. Are there any changes to client_test? I remember that file already had a lot of coverage so if changing the error string and adding the new MKDIR check are covered by the unhappy path tests already then 🟢
|
yeah, I can update the client tests for this -- thanks @spiffcs |
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few assumptions made by the v6 curator surrounding DB directory existence. This PR fixes activation-related issues with the DB not existing.