chore: disable auto-merge on human push to dependabot PR #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dependabot PR fails and a human starts interacting with it to try to unblock it, it would previously be left with auto-merge enabled, which would surprise the human if, for example, they pushed an experimental change meant to unblock CI, and it accidentally ended up on main. Therefore, if an author besides dependabot pushes to the dependabot PR, disable the auto-merge. Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
commented
Dec 15, 2023
| echo "Additional PR Authors: $EXTRA_AUTHORS" | ||
| echo "::set-output name=extra_pr_authors::$EXTRA_AUTHORS" | ||
| if [ -n "$EXTRA_AUTHORS" ]; then | ||
| echo "::set-output name=human_pushed::true" |
There was a problem hiding this comment.
From @wagoodman offline: We should use >> $GITHUB_OUTPUT instead, the ::set-output still works, but is no longer recommended.
|
We are iterating on this workflow over in bubbly, see for example anchore/bubbly#34. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dependabot PR fails and a human starts interacting with it to try to unblock it, it would previously be left with auto-merge enabled, which would surprise the human if, for example, they pushed an experimental change meant to unblock CI, and it accidentally ended up on main. Therefore, if an author besides dependabot pushes to the dependabot PR, disable the auto-merge.