Update expired test fixtures #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
update-fixtures
branch
from
e7b05a8 to
f2f534e
Compare
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
commented
Nov 8, 2024
| @@ -33,7 +33,7 @@ SUCCESS := $(BOLD)$(GREEN) | |||
|
|
|||
| # Test variables ################################# | |||
| # the quality gate lower threshold for unit test total % coverage (by function statements) | |||
| COVERAGE_THRESHOLD := 45 | |||
| COVERAGE_THRESHOLD := 30 | |||
There was a problem hiding this comment.
go 1.22 changed the rules around how coverage is counted -- this new value reflects within 2% of where we are today
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few test fixture certs have an expiration period. For one of the fixtures I upped the period so we don't need to do this as frequently. There were a couple of extra/unnecessary flags present that the latest openssl now fails on, so they were removed.
Additionally it was necessary to update the version of go used as well as the linter version (these go hand in hand). In doing so I used the main linter config we have in syft here as well.