always output SBOM table #238
Conversation
Signed-off-by: Jonas Galvão Xavier <[email protected]>
jonasagx
force-pushed
the
show-sbom-table
branch
from
c7bb0d8 to
be9b4be
Compare
Signed-off-by: Jonas Galvão Xavier <[email protected]>
Signed-off-by: Jonas Galvão Xavier <[email protected]>
| @@ -126,7 +126,7 @@ async function executeSyft({ | |||
| throw new Error("Invalid input, no image or path specified"); | |||
| } | |||
|
|
|||
| args = [...args, "-o", format]; | |||
| args = [...args, "-o", format, "-o", "table"]; | |||
There was a problem hiding this comment.
I don't think this is going to work correctly. The way the code currently works, syft is invoked and the stdout captured as the sbom. Looking at the changes in the snapshots, this change seems to have caused multiple types of SBOMs to be output to stdout. Instead, we'd need to do something like syft -o table -o spdx-json=some-file.spdx.json and then instead of using stdout as the sbom, just print stdout to the console as this would have the table output, and then read or otherwise use the sbom file.
There was a problem hiding this comment.
Oh I see :) I got it really wrong.
|
We discussed this a while ago, but I'm not actually sure this is especially useful. More useful would be a convert command, if someone really wanted a text version of the SBOM dumped to the logs, it would be a simple script using syft to convert an sbom to the table view. |
|
@kzantow agreed, I should have closed that issue (or had it waiting) in favor of the conversion approach. |
Always print SBOM as table, even with file output.
Closes: #46
Signed-off-by: Jonas Galvão Xavier [email protected]