Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update minimum supported go version to 1.22.9 #320

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: update minimum supported go version to 1.22.9 #320

merged 1 commit into from
Nov 7, 2024

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Nov 7, 2024 •
edited by wagoodman
Loading

Updates minimum go version to 1.22.9

@kzantow
chore: update go version
6b75ae0 
Signed-off-by: Keith Zantow <[email protected]>
@wagoodman wagoodman changed the title chore: update go version chore: update minimum supported go version to 1.22.9 Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
make .tool/task
make[1]: Entering directory '/home/runner/work/stereoscope/stereoscope'
make[1]: Leaving directory '/home/runner/work/stereoscope/stereoscope'
.tool/task show-benchstat
?   	github.com/anchore/stereoscope	[no test files]
?   	github.com/anchore/stereoscope/examples	[no test files]
PASS
ok  	github.com/anchore/stereoscope/internal	0.004s
?   	github.com/anchore/stereoscope/internal/bus	[no test files]
PASS
ok  	github.com/anchore/stereoscope/internal/containerd	0.007s
PASS
ok  	github.com/anchore/stereoscope/internal/docker	0.005s
?   	github.com/anchore/stereoscope/internal/log	[no test files]
PASS
ok  	github.com/anchore/stereoscope/internal/podman	0.005s
?   	github.com/anchore/stereoscope/pkg/event	[no test files]
?   	github.com/anchore/stereoscope/pkg/event/parsers	[no test files]
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkTarIndex-4   	   33720	     35597 ns/op	    5699 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33495	     35682 ns/op	    5698 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33526	     35588 ns/op	    5699 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33579	     35587 ns/op	    5697 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   32662	     35556 ns/op	    5699 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33270	     35597 ns/op	    5700 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33582	     35661 ns/op	    5699 B/op	      93 allocs/op
PASS
ok  	github.com/anchore/stereoscope/pkg/file	10.888s
PASS
ok  	github.com/anchore/stereoscope/pkg/filetree	0.004s
?   	github.com/anchore/stereoscope/pkg/filetree/filenode	[no test files]
PASS
ok  	github.com/anchore/stereoscope/pkg/image	0.005s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/containerd	0.009s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/docker	0.005s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/oci	0.005s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/oci/credhelpers	0.005s
?   	github.com/anchore/stereoscope/pkg/image/podman	[no test files]
PASS
ok  	github.com/anchore/stereoscope/pkg/image/sif	0.004s
?   	github.com/anchore/stereoscope/pkg/imagetest	[no test files]
PASS
ok  	github.com/anchore/stereoscope/pkg/tree	0.003s
PASS
ok  	github.com/anchore/stereoscope/pkg/tree/node	0.003s
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/test/integration
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1076	   1113402 ns/op	  274361 B/op	    2313 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1080	   1110623 ns/op	  273898 B/op	    2312 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1075	   1108627 ns/op	  273770 B/op	    2312 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1076	   1103022 ns/op	  273735 B/op	    2311 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1078	   1233548 ns/op	  273697 B/op	    2311 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1062	   1144533 ns/op	  273564 B/op	    2311 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1077	   1131771 ns/op	  273619 B/op	    2311 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      69	  17065507 ns/op	  401892 B/op	    2701 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      68	  17062225 ns/op	  402524 B/op	    2701 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      72	  17128058 ns/op	  401798 B/op	    2701 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      67	  18414727 ns/op	  401626 B/op	    2701 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      66	  17249087 ns/op	  401098 B/op	    2699 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      69	  17195375 ns/op	  400779 B/op	    2698 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      67	  16832165 ns/op	  402016 B/op	    2701 allocs/op
#0 building with "default" instance using docker driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 345B done
#1 DONE 0.0s

#2 [internal] load .dockerignore
#2 transferring context: 2B done
#2 DONE 0.0s

#3 [internal] load build context
#3 transferring context: 209B done
#3 DONE 0.0s

#4 [1/3] ADD file-1.txt /somefile-1.txt
#4 CACHED

#5 [2/3] ADD file-2.txt /somefile-2.txt
#5 CACHED

#6 [3/3] ADD target /
#6 CACHED

#7 exporting to image
#7 exporting layers done
#7 writing image sha256:7ecb8b5d3fe7345cd0e6e5b58ddde58fd9fda078148279e51670d6f056b33452 done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7 done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:latest done
#7 DONE 0.0s
ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
--- FAIL: BenchmarkSimpleImage_GetImage
    image_fixtures.go:193: using existing image tar: 'test-fixtures/cache/stereoscope-fixture-image-simple-04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7.tar' (size: 22528, modified: 2024-11-07 15:06:39.041064413 +0000 UTC, mode: -rw-r--r--)
    image_fixtures.go:241: Build docker image: name="stereoscope-fixture-image-simple" tag="04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7"
    image_fixtures.go:291: saveImage running: docker image save stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7
    image_fixtures.go:286: 
        	Error Trace:	/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:286
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:162
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:152
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:33
        	            				/home/runner/work/stereoscope/stereoscope/test/integration/fixture_image_simple_test.go:163
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	BenchmarkSimpleImage_GetImage
        	Messages:   	could not import docker image to containerd (shell out)
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   55070	     21974 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   54128	     22231 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53730	     22248 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53265	     22295 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   52998	     22193 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   54056	     22234 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   54105	     22211 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53832	     22274 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53956	     22158 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53884	     22255 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53725	     22219 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53869	     22292 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   54214	     22166 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53811	     22198 ns/op	    2712 B/op	      21 allocs/op
#0 building with "default" instance using docker driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 345B done
#1 DONE 0.0s

#2 [internal] load .dockerignore
#2 transferring context: 2B done
#2 DONE 0.0s

#3 [internal] load build context
#3 transferring context: 209B done
#3 DONE 0.0s

#4 [1/3] ADD file-1.txt /somefile-1.txt
#4 CACHED

#5 [2/3] ADD file-2.txt /somefile-2.txt
#5 CACHED

#6 [3/3] ADD target /
#6 CACHED

#7 exporting to image
#7 exporting layers done
#7 writing image sha256:7ecb8b5d3fe7345cd0e6e5b58ddde58fd9fda078148279e51670d6f056b33452 done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7 done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:latest done
#7 DONE 0.0s
ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
--- FAIL: BenchmarkSimpleImage_FetchSquashedContents
    image_fixtures.go:193: using existing image tar: 'test-fixtures/cache/stereoscope-fixture-image-simple-04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7.tar' (size: 22528, modified: 2024-11-07 15:06:39.041064413 +0000 UTC, mode: -rw-r--r--)
    image_fixtures.go:241: Build docker image: name="stereoscope-fixture-image-simple" tag="04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7"
    image_fixtures.go:291: saveImage running: docker image save stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7
    image_fixtures.go:286: 
        	Error Trace:	/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:286
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:162
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:152
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:33
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:64
        	            				/home/runner/work/stereoscope/stereoscope/test/integration/fixture_image_simple_test.go:189
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	BenchmarkSimpleImage_FetchSquashedContents
        	Messages:   	could not import docker image to containerd (shell out)
FAIL
exit status 1
FAIL	github.com/anchore/stereoscope/test/integration	39.286s
?   	github.com/anchore/stereoscope/test/integration/test-fixtures/registry	[no test files]
FAIL
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: AMD EPYC 7763 64-Core Processor                
ctr: 
           │ .tmp/benchmark-d3d2ab5.txt │
           │           sec/op           │
TarIndex-4                  35.60µ ± 0%

           │ .tmp/benchmark-d3d2ab5.txt │
           │            B/op            │
TarIndex-4                 5.565Ki ± 0%

           │ .tmp/benchmark-d3d2ab5.txt │
           │         allocs/op          │
TarIndex-4                   93.00 ± 0%

pkg: github.com/anchore/stereoscope/test/integration
                                      │ .tmp/benchmark-d3d2ab5.txt │
                                      │           sec/op           │
SimpleImage_GetImage/docker-archive-4                 1.113m ± 11%
SimpleImage_GetImage/podman-4                         17.13m ±  8%
geomean                                               4.367m

                                      │ .tmp/benchmark-d3d2ab5.txt │
                                      │            B/op            │
SimpleImage_GetImage/docker-archive-4                 267.3Ki ± 0%
SimpleImage_GetImage/podman-4                         392.4Ki ± 0%
geomean                                               323.9Ki

                                      │ .tmp/benchmark-d3d2ab5.txt │
                                      │         allocs/op          │
SimpleImage_GetImage/docker-archive-4                  2.311k ± 0%
SimpleImage_GetImage/podman-4                          2.701k ± 0%
geomean                                                2.498k

ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
                                                   │ .tmp/benchmark-d3d2ab5.txt │
                                                   │           sec/op           │
SimpleImage_FetchSquashedContents/docker-archive-4                  22.23µ ± 1%
SimpleImage_FetchSquashedContents/podman-4                          22.22µ ± 0%
geomean                                                             22.22µ

                                                   │ .tmp/benchmark-d3d2ab5.txt │
                                                   │            B/op            │
SimpleImage_FetchSquashedContents/docker-archive-4                 2.648Ki ± 0%
SimpleImage_FetchSquashedContents/podman-4                         2.648Ki ± 0%
geomean                                                            2.648Ki

                                                   │ .tmp/benchmark-d3d2ab5.txt │
                                                   │         allocs/op          │
SimpleImage_FetchSquashedContents/docker-archive-4                   21.00 ± 0%
SimpleImage_FetchSquashedContents/podman-4                           21.00 ± 0%
geomean                                                              21.00
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: AMD EPYC 7763 64-Core Processor                
ctr: 
           │ .tmp/benchmark-d3d2ab5.txt │
           │           sec/op           │
TarIndex-4                  35.60µ ± 0%

           │ .tmp/benchmark-d3d2ab5.txt │
           │            B/op            │
TarIndex-4                 5.565Ki ± 0%

           │ .tmp/benchmark-d3d2ab5.txt │
           │         allocs/op          │
TarIndex-4                   93.00 ± 0%

pkg: github.com/anchore/stereoscope/test/integration
                                      │ .tmp/benchmark-d3d2ab5.txt │
                                      │           sec/op           │
SimpleImage_GetImage/docker-archive-4                 1.113m ± 11%
SimpleImage_GetImage/podman-4                         17.13m ±  8%
geomean                                               4.367m

                                      │ .tmp/benchmark-d3d2ab5.txt │
                                      │            B/op            │
SimpleImage_GetImage/docker-archive-4                 267.3Ki ± 0%
SimpleImage_GetImage/podman-4                         392.4Ki ± 0%
geomean                                               323.9Ki

                                      │ .tmp/benchmark-d3d2ab5.txt │
                                      │         allocs/op          │
SimpleImage_GetImage/docker-archive-4                  2.311k ± 0%
SimpleImage_GetImage/podman-4                          2.701k ± 0%
geomean                                                2.498k

ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
                                                   │ .tmp/benchmark-d3d2ab5.txt │
                                                   │           sec/op           │
SimpleImage_FetchSquashedContents/docker-archive-4                  22.23µ ± 1%
SimpleImage_FetchSquashedContents/podman-4                          22.22µ ± 0%
geomean                                                             22.22µ

                                                   │ .tmp/benchmark-d3d2ab5.txt │
                                                   │            B/op            │
SimpleImage_FetchSquashedContents/docker-archive-4                 2.648Ki ± 0%
SimpleImage_FetchSquashedContents/podman-4                         2.648Ki ± 0%
geomean                                                            2.648Ki

                                                   │ .tmp/benchmark-d3d2ab5.txt │
                                                   │         allocs/op          │
SimpleImage_FetchSquashedContents/docker-archive-4                   21.00 ± 0%
SimpleImage_FetchSquashedContents/podman-4                           21.00 ± 0%
geomean                                                              21.00

@kzantow kzantow merged commit 120d9ea into main Nov 7, 2024
7 checks passed
@kzantow kzantow deleted the chore/bump-go-version branch November 7, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzantow @wagoodman