Small typo on type of fmap in List_Functor_Type #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elvanMadhavan-patch-1 Update README.md
Change signature of fmap in List_Functor_Type to type 'b list.
In some cases I have added a suggestion or an alternative definition as a comment. Feel free to choose the one you prefer and delete the other
In particular, a lot of type annotations are not needed once you have defined the module signature. Moreover in all cases you don't need the `'a 'b 'c .` parts
Chapter 7: some suggestions
Chapter 8: suggestions
Chapter 9: some suggestions
With these changes, you can make a bigger part of this chapter compile as proper ocaml. With some more work on the signature one could work in functors and make most of the rest typeset as well.
…i-patch-2 Chapter 25: comments
…i-patch-1 Review of 26, 27 and 30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bellive I found a small typo of fmap in List_Functor_Type.