Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator command tests. #755

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

tsommie
Copy link

@tsommie tsommie commented May 9, 2021

Thanks to everyone maintaining this package, I wonder why Tailor is yet to add repositories to Laravel. After years of using this package, I decided to contribute to it but first I needed a safety net to make sure I don't break anything.

This PR includes tests for the generator command classes only.
This PR does not include tests for the eloquent repository class.

Few suggestions:

  • The Laravel community is changing and considering how opinionated this package is, it has become a little unintuitive to use. Considering the introduction of Inertia.Js and Livewire it is safe to say that the nake:entity command is not very flexible.
  • Different branches should be created to support different versions of Laravel and not have every release support all versions of Laravel since version 5.
  • Committing the composer.lock file is not neccessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants