Fix locking issue and optimize a bit #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue with locking by creating just a single PePuRunner on the process start up in run_pepubot function. Previously a new PePuRunner was created for each incoming Slack message and the locking of the shared resources (e.g. runner state and the lottery box) was done with an instance attribute of the PePuRunner. Therefore there was actually a different lock for each PePuRunner and the locking wasn't able to protect two distinct message processing flows to mess up each other.
There is no need to load the state of the PePuRunner more than once. Now that there is only a single PePuRunner instantiated, this actually makes a difference too.
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
- Coverage 34.16% 33.71% -0.46%
==========================================
Files 11 11
Lines 518 522 +4
Branches 74 75 +1
==========================================
- Hits 177 176 -1
- Misses 340 345 +5
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with locking by creating just a single PePuRunner on the
process start up in run_pepubot function.
Previously a new PePuRunner was created for each incoming Slack message
and the locking of the shared resources (e.g. runner state and the
lottery box) was done with an instance attribute of the
PePuRunner. Therefore there was actually a different lock for each
PePuRunner and the locking wasn't able to protect two distinct message
processing flows to mess up each other.
Also add an optimization that skips the state loading when its already
loaded.
Fixes #2