Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zoom, text and eraser #153

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bowespublishing
Copy link

@bowespublishing bowespublishing commented Sep 23, 2024

Added zoom, image, text and eraser

Added zoom, text and eraser
@luciacilla
Copy link

luciacilla commented Nov 25, 2024

I have been trying your fork, and the zoom-in and zoom-out features work perfectly. Great work on the auto-adjust button as well—it's really convenient.

However, there is an issue with the polygon drawer that is not present in the official version. The zones do not close with the right button, making it almost impossible to draw a zone correctly. (The blue zone is from the official version, the yellow one is my attempt to draw a new one)

Captura desde 2024-11-25 14-42-58

image

@luciacilla
Copy link

Following the above comment, I have been doing some checks and found that the issue is related to the chosen web browser. It causes problems when closing the zones in Firefox; however, it works perfectly on Google Chrome.

@chraibi
Copy link

chraibi commented Nov 29, 2024

Do you get the correct coordinates of the polygon after zooming?

@bowespublishing
Copy link
Author

Sorry I’ve only tried on Chrome. Strange issue however as I haven’t touched that tool, I only bumped the fabric js version a little to support the eraser. I do actually have a more updated version, with better text, inserting images etc just not pushed to GitHub yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants