Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache idx passed to constructor #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: cache idx passed to constructor #99

wants to merge 1 commit into from
+4 −0

Conversation

panahiparham
Copy link

@panahiparham panahiparham commented Dec 23, 2024 •
edited
Loading

Setting the index inside the Collector's constructor does not add it to self._idxs and causes saveCollector to skip saving the results. This pr adds the logic to conditionally add the idx to self._idxs if it is not None.

fixes #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collector does not save results if setting idx in constructor
1 participant
@panahiparham