-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ratio theme #160
base: main
Are you sure you want to change the base?
Add Ratio theme #160
Conversation
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
I did some cleanup today, as well as properly "namespacing" everything except the slide functions by means of prefixing it with |
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Whelp, I always lose myself in these kind of theme updates. Pretty satisfied for now. |
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
Signed-off-by: Tiemen Schuijbroek <[email protected]>
@andreasKroepelin ping 👍 Would love to see this merged. |
It is unlikely to get merged. Since the advent of proper Typst templates, this should get published as a stand alone template (as will the other builtin Polylux themes at some point). |
I mean sure, I understand you, but there is a change in utils in this MR which adds subsection registering. This makes this template not compatible with the current release of polylux unfortunately. Probably only merging changes in utils, so that it possible to show the progress in subsection steps? 🤔 |
I think the utils part could be handled separately and perhaps could be generalized further into a variable heading level if I remember correctly. Regarding the theme, I have some local changes/additions and might revise it a bit more for the latest Typst. Would you consider adding more themes in the general sense or is that just a no-go? |
@andreasKroepelin I seem to have glossed over your comment and will investigate the standalone solution some more, which is fine but I'm not sure when I'm going to get to it. Shall we close this in favor of an issue/PR with variable depth sections? I think that would be a useful addition to the toolkit. |
That sounds reasonable. |
Whelp, it's easy to get sidetracked with these themes. I did a rewrite of the theme and put a repository up over at |
Hi there!
I started playing around with polylux and thought I could contribute another theme!
Would you mind taking a look?
ratio.pdf