Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link and expand JSON schema for easier editing of library file #40

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

deosrc
Copy link
Contributor

@deosrc deosrc commented Dec 12, 2023

Excited to see where this project goes!

This is just to make editing the library file a bit easier in editors. Tested in VSCode.

Note that the minimum on battery quantity is exclusive. Using 1 prevents 1 or lower as a value.

@andrew-codechimp andrew-codechimp merged commit a7fc903 into andrew-codechimp:main Dec 12, 2023
3 of 4 checks passed
@andrew-codechimp
Copy link
Owner

Thanks for this, I have only just got into json schema validation and this really improves things and increases my knowledge in this area.

@andrew-codechimp
Copy link
Owner

I'm having some issues with paths and the GH Action to validate.

I rushed the merge and my quick bodges didn't fix it so I've had to revert the change for now until I have time to look at it in more detail.

@andrew-codechimp
Copy link
Owner

And it turns out I was using a dodgy GHA validator that didn't like the paths.
Switched to the more popular one and this is now working like a charm :)
Finalising the library at the moment so it's all a bit of a rush and I'm not the most disciplined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants